Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use lib/purple-2 directory instead of lib/pidgin #38311

Merged
merged 1 commit into from Apr 17, 2018
Merged

Use lib/purple-2 directory instead of lib/pidgin #38311

merged 1 commit into from Apr 17, 2018

Conversation

qfjp
Copy link
Contributor

@qfjp qfjp commented Apr 1, 2018

Motivation for this change

This plugin should be available for all libpurple applications, but currently it is only available for pidgin

Things done

Changed output directory to $out/lib/purple-2 (e.g. as in nixpkgs.pidgin-opensteamworks)

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jtojnar jtojnar mentioned this pull request Apr 12, 2018
Merged
8 tasks
@matthewbauer matthewbauer merged commit 3207b7e into NixOS:master Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@qfjp @matthewbauer @GrahamcOfBorg @Janik-Haag