A benchmark for PlotMethod2 #1785
Merged
+251
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleroy
reviewed
Apr 1, 2018
benchmarks/benchmarks.vcxproj
Outdated
| <ClCompile Include="dynamic_frame.cpp" /> | ||
| <ClCompile Include="embedded_explicit_runge_kutta_nyström_integrator.cpp" /> | ||
| <ClCompile Include="ephemeris.cpp" /> | ||
| <ClCompile Include="hexadecimal.cpp" /> | ||
| <ClCompile Include="main.cpp" /> | ||
| <ClCompile Include="newhall.cpp" /> | ||
| <ClCompile Include="perspective.cpp" /> | ||
| <ClCompile Include="planetarium_benchmarks.cpp" /> |
There was a problem hiding this comment.
In general we don't call benchmarks _benchmarks.
There was a problem hiding this comment.
Yes, but if there are two translation units with the same name in the same project MSVC complains that the object files have the same name.
| *goes_8_instance)); | ||
| } | ||
|
|
||
| DiscreteTrajectory<Barycentric> const& GOES8Trajectory() const { |
There was a problem hiding this comment.
Should this function use snake_case?
| RP2Lines<Length, Camera> lines; | ||
| int total_lines = 0; | ||
| int iterations = 0; | ||
| constexpr Instant now = "2000-01-21T04:41:30,5"_TT; |
There was a problem hiding this comment.
It's an eclipse that happened to be in January of 2000.
| RunBenchmark(state, PolarPerspective(near)); | ||
| } | ||
|
|
||
| BENCHMARK(BM_PlanetariumPlotMethod2NearPolarPerspective); |
There was a problem hiding this comment.
Move all the macros together at the end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that we mostly spend time in
lower_bound: