Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GHCJS 7.10 #38314

Merged
merged 1 commit into from Apr 3, 2018
Merged

Fix GHCJS 7.10 #38314

merged 1 commit into from Apr 3, 2018

Conversation

ElvishJerricco
Copy link
Contributor

Motivation for this change

Fixes the old version of GHCJS

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

/cc @dmjio

@peti
Copy link
Member

peti commented Apr 2, 2018

@GrahamcOfBorg build haskellPackages.ghcjs

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: haskellPackages.ghcjs

Partial log (click to expand)

Cannot nix-instantiate `haskellPackages.ghcjs' because:
�[31;1merror:�[0m attribute 'ghcjs' in selection path 'haskellPackages.ghcjs' not found

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: haskellPackages.ghcjs

Partial log (click to expand)

Cannot nix-instantiate `haskellPackages.ghcjs' because:
�[31;1merror:�[0m attribute 'ghcjs' in selection path 'haskellPackages.ghcjs' not found

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: haskellPackages.ghcjs

Partial log (click to expand)

Cannot nix-instantiate `haskellPackages.ghcjs' because:
�[31;1merror:�[0m attribute 'ghcjs' in selection path 'haskellPackages.ghcjs' not found

@peti
Copy link
Member

peti commented Apr 2, 2018

@GrahamcOfBorg build haskell.compiler.ghcjs

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: haskell.compiler.ghcjs

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

peti
peti approved these changes Apr 2, 2018
View reviewed changes
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I triggered a test build, just to be on the safe side.

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: haskell.compiler.ghcjs

Partial log (click to expand)

/nix/store/ffmg42gvar5iq0mkwh9dig29agbzlfzc-kan-extensions-5.1/lib/ghc-7.10.3/package.conf.d/kan-extensions-5.1.conf
post-installation fixup
strip is /nix/store/0fzpxnsanc02i4jsb1yhchjp4p62b2n3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/ffmg42gvar5iq0mkwh9dig29agbzlfzc-kan-extensions-5.1/lib
patching script interpreter paths in /nix/store/ffmg42gvar5iq0mkwh9dig29agbzlfzc-kan-extensions-5.1
strip is /nix/store/0fzpxnsanc02i4jsb1yhchjp4p62b2n3-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/llxldrfsddl3cwvzvj7s4if9brj2svwi-kan-extensions-5.1-doc
cannot build derivation '/nix/store/0546hkk3450yn4h07xdv5k8ixlzi5fyc-lens-4.16.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/j3ddmwybr3hdykq7mjp5d98kvv1rlzqz-ghcjs-0.2.0.drv': 9 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/j3ddmwybr3hdykq7mjp5d98kvv1rlzqz-ghcjs-0.2.0.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: haskell.compiler.ghcjs

Partial log (click to expand)

wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
/nix/store/k1by43k0il5a4nj2b51qjmszw0zg9s07-ghcjs-0.2.0

@peti peti merged commit 97e891a into NixOS:master Apr 3, 2018
@dmjio
Copy link
Member

dmjio commented Apr 3, 2018

@grahamc @peti @ElvishJerricco awesome! I assume this means haskell.compiler.ghcjs builds on Darwin as well? Couldn't tell after this comment: #38314 (comment)

@ElvishJerricco
Copy link
Contributor Author

@dmjio Hm I never tested the build on darwin, but that does look like a failure :/

@ElvishJerricco
Copy link
Contributor Author

@dmjio Just tried it on my macbook. Built fine. Though I'm only on Sierra, not High Sierra

@dmjio
Copy link
Member

dmjio commented Apr 3, 2018

@ElvishJerricco beat me to it. Good enough for now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti peti approved these changes

Assignees
No one assigned
Labels
6.topic: haskell 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ElvishJerricco @peti @GrahamcOfBorg @dmjio