Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wine: 3.4 -> 3.5 #38308

Merged
merged 1 commit into from Apr 9, 2018
Merged

wine: 3.4 -> 3.5 #38308

merged 1 commit into from Apr 9, 2018

Conversation

ikervagyok
Copy link
Contributor

Motivation for this change

simple update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Chiiruno
Copy link
Contributor

Chiiruno commented Apr 2, 2018

I was just about to do this.
Thanks.

@infinisil
Copy link
Member

@GrahamcOfBorg build wine wineStaging

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: wine, wineStaging

Partial log (click to expand)

Cannot nix-instantiate `wineStaging' because:
�[31;1merror:�[0m while evaluating 'lowPrio' at �[1m/var/lib/gc-of-borg/nix-test-rs-17/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-17/lib/meta.nix�[0m:52:13, called from �[1m/var/lib/gc-of-borg/nix-test-rs-17/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-17/pkgs/top-level/all-packages.nix�[0m:20903:17:
while evaluating 'addMetaAttrs' at �[1m/var/lib/gc-of-borg/nix-test-rs-17/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-17/lib/meta.nix�[0m:15:28, called from �[1m/var/lib/gc-of-borg/nix-test-rs-17/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-17/lib/meta.nix�[0m:52:18:
while evaluating the attribute 'full.override' at �[1m/var/lib/gc-of-borg/nix-test-rs-17/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-17/pkgs/top-level/all-packages.nix�[0m:20879:5:
while evaluating 'callPackageWith' at �[1m/var/lib/gc-of-borg/nix-test-rs-17/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-17/lib/customisation.nix�[0m:113:35, called from �[1m/var/lib/gc-of-borg/nix-test-rs-17/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-17/pkgs/top-level/all-packages.nix�[0m:20854:15:
while evaluating 'makeOverridable' at �[1m/var/lib/gc-of-borg/nix-test-rs-17/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-17/lib/customisation.nix�[0m:72:24, called from �[1m/var/lib/gc-of-borg/nix-test-rs-17/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-17/lib/customisation.nix�[0m:117:8:
while evaluating anonymous function at �[1m/var/lib/gc-of-borg/nix-test-rs-17/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-17/pkgs/misc/emulators/wine/default.nix�[0m:9:1, called from �[1m/var/lib/gc-of-borg/nix-test-rs-17/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-17/lib/customisation.nix�[0m:74:12:
while evaluating 'wine-build' at �[1m/var/lib/gc-of-borg/nix-test-rs-17/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-17/pkgs/misc/emulators/wine/default.nix�[0m:45:25, called from �[1m/var/lib/gc-of-borg/nix-test-rs-17/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-17/pkgs/misc/emulators/wine/default.nix�[0m:64:3:
callPackage_i686 not supported on system 'aarch64-linux'

@ikervagyok
Copy link
Contributor Author

@infinisil to be precise, it's wineUnstable and wineStaging, i didn't touch wine (the stable one) ;)

@ikervagyok
Copy link
Contributor Author

@GrahamcOfBorg build wineUnstable

@infinisil
Copy link
Member

Ahh right, go do your thing bot!
@GrahamcOfBorg build wineUnstable

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: wineUnstable

Partial log (click to expand)

while evaluating 'isDerivation' at �[1m/var/lib/gc-of-borg/nix-test-rs-28/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-28/lib/attrsets.nix�[0m:295:18, called from �[1m/var/lib/gc-of-borg/nix-test-rs-28/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-28/pkgs/top-level/aliases.nix�[0m:16:8:
while evaluating 'removeRecurseForDerivations' at �[1m/var/lib/gc-of-borg/nix-test-rs-28/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-28/pkgs/top-level/aliases.nix�[0m:8:33, called from �[1m/var/lib/gc-of-borg/nix-test-rs-28/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-28/pkgs/top-level/aliases.nix�[0m:21:47:
while evaluating the attribute 'wineUnstable' at �[1m/var/lib/gc-of-borg/nix-test-rs-28/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-28/pkgs/top-level/aliases.nix�[0m:236:3:
while evaluating the attribute 'unstable' at �[1m/var/lib/gc-of-borg/nix-test-rs-28/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-28/pkgs/top-level/all-packages.nix�[0m:20897:5:
while evaluating 'callPackageWith' at �[1m/var/lib/gc-of-borg/nix-test-rs-28/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-28/lib/customisation.nix�[0m:113:35, called from �[1m/var/lib/gc-of-borg/nix-test-rs-28/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-28/pkgs/top-level/all-packages.nix�[0m:20854:15:
while evaluating 'makeOverridable' at �[1m/var/lib/gc-of-borg/nix-test-rs-28/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-28/lib/customisation.nix�[0m:72:24, called from �[1m/var/lib/gc-of-borg/nix-test-rs-28/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-28/lib/customisation.nix�[0m:117:8:
while evaluating anonymous function at �[1m/var/lib/gc-of-borg/nix-test-rs-28/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-28/pkgs/misc/emulators/wine/default.nix�[0m:9:1, called from �[1m/var/lib/gc-of-borg/nix-test-rs-28/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-28/lib/customisation.nix�[0m:74:12:
while evaluating 'wine-build' at �[1m/var/lib/gc-of-borg/nix-test-rs-28/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-28/pkgs/misc/emulators/wine/default.nix�[0m:45:25, called from �[1m/var/lib/gc-of-borg/nix-test-rs-28/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-28/pkgs/misc/emulators/wine/default.nix�[0m:64:3:
callPackage_i686 not supported on system 'aarch64-linux'

@infinisil
Copy link
Member

(For now only people in https://github.com/NixOS/ofborg/blob/released/config.extra-known-users.json are allowed to ask the bot to build something)

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: wine, wineStaging

Partial log (click to expand)

test [codegen] codegen/vec-optimizes-away.rs ... ok
test [codegen] codegen/remap_path_prefix/main.rs ... ok
test [codegen] codegen/x86_mmx.rs ... ok
test [codegen] codegen/zip.rs ... ok
building of '/nix/store/9pg262axywa6jlv10731vlldc4hzyy8p-rustc-1.24.0.drv' timed out after 4000 seconds
cannot build derivation '/nix/store/acq1qgbgxsz5pnlfscj9bmh63qcwygn4-cargo-0.24.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/1l0kfja1xgaj0jv3d3h4xb2ic51ykkyi-librsvg-2.42.2.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/70wi37pvp4r16snpv59cyz31jjyixpgl-gst-plugins-bad-1.12.3.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/jmzg674ksbcdibyb4rhn6p0jnsazn3qx-wine-3.5-staging.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/jmzg674ksbcdibyb4rhn6p0jnsazn3qx-wine-3.5-staging.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: wineUnstable

Partial log (click to expand)

/nix/store/gxvy5mwx3qbfywznm07sihlixml7fqbz-wine-3.5/bin/winedbg: interpreter directive changed from "/bin/sh" to "/nix/store/rw0zn08j64ckrmam47b3wbpn00cnya1z-bash-4.4-p19/bin/sh"
/nix/store/gxvy5mwx3qbfywznm07sihlixml7fqbz-wine-3.5/bin/regsvr32: interpreter directive changed from "/bin/sh" to "/nix/store/rw0zn08j64ckrmam47b3wbpn00cnya1z-bash-4.4-p19/bin/sh"
/nix/store/gxvy5mwx3qbfywznm07sihlixml7fqbz-wine-3.5/bin/winefile: interpreter directive changed from "/bin/sh" to "/nix/store/rw0zn08j64ckrmam47b3wbpn00cnya1z-bash-4.4-p19/bin/sh"
/nix/store/gxvy5mwx3qbfywznm07sihlixml7fqbz-wine-3.5/bin/winemine: interpreter directive changed from "/bin/sh" to "/nix/store/rw0zn08j64ckrmam47b3wbpn00cnya1z-bash-4.4-p19/bin/sh"
/nix/store/gxvy5mwx3qbfywznm07sihlixml7fqbz-wine-3.5/bin/winecfg: interpreter directive changed from "/bin/sh" to "/nix/store/rw0zn08j64ckrmam47b3wbpn00cnya1z-bash-4.4-p19/bin/sh"
/nix/store/gxvy5mwx3qbfywznm07sihlixml7fqbz-wine-3.5/bin/winepath: interpreter directive changed from "/bin/sh" to "/nix/store/rw0zn08j64ckrmam47b3wbpn00cnya1z-bash-4.4-p19/bin/sh"
/nix/store/gxvy5mwx3qbfywznm07sihlixml7fqbz-wine-3.5/bin/msiexec: interpreter directive changed from "/bin/sh" to "/nix/store/rw0zn08j64ckrmam47b3wbpn00cnya1z-bash-4.4-p19/bin/sh"
/nix/store/gxvy5mwx3qbfywznm07sihlixml7fqbz-wine-3.5/bin/wineconsole: interpreter directive changed from "/bin/sh" to "/nix/store/rw0zn08j64ckrmam47b3wbpn00cnya1z-bash-4.4-p19/bin/sh"
checking for references to /tmp/nix-build-wine-3.5.drv-0 in /nix/store/gxvy5mwx3qbfywznm07sihlixml7fqbz-wine-3.5...
cannot find section .dynamic

@ikervagyok
Copy link
Contributor Author

thanks, good to know - didn't know that

@infinisil
Copy link
Member

infinisil commented Apr 3, 2018 •
edited

It seems that the indirect dependency rustc fails, even in master. I'll run a git bisect to hopefully find the cause. See https://hydra.nixos.org/build/72311474

Edit: Didn't find anything, maybe an impurity

@ikervagyok
Copy link
Contributor Author

the build of wineStaging died with a timeout, the one you linked used too much memory.

for a workaround i could try:

  • disabling gstreamer for wineStaging, which would probably remove the rustc dependency for now.
  • set wineStaging = winePackages.staging, which would enable the same optional features as the stable wine package

(both in all-packages.nix)
@infinisil any suggestions on what would be better? or just wait for a successful rustc-build?

@infinisil
Copy link
Member

@ikervagyok I'm honestly not even sure why rustc gets rebuilt for this at all. Because the normal rustc build is succeeding. Imo trying to figure out what's wrong would be better and only disable the not working parts if we really have no idea what to do anymore. (I personally don't feel like messing with wine right now though)

@ikervagyok
Copy link
Contributor Author

it's probably this line, but i am not sure about how nativeBuildInputs should behave:

nixpkgs/pkgs/development/libraries/librsvg/default.nix

Line 26 in a4581f5

nativeBuildInputs = [ pkgconfig rust.rustc rust.cargo vala gobjectIntrospection ]

@matthewbauer matthewbauer merged commit e05cd54 into NixOS:master Apr 9, 2018
@Chiiruno Chiiruno mentioned this pull request Apr 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ikervagyok @Chiiruno @infinisil @GrahamcOfBorg @matthewbauer