Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openshift: Fix binary paths for oc cluster up to work #38321

Merged
merged 1 commit into from Apr 17, 2018
Merged

openshift: Fix binary paths for oc cluster up to work #38321

merged 1 commit into from Apr 17, 2018

Conversation

jensbin
Copy link
Contributor

@jensbin jensbin commented Apr 2, 2018 •
edited

Motivation for this change

When upgrading to newer release (#37882) I messed up the "oc cluster up" by removing the patch section. Bringing back this functionality.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jensbin jensbin changed the title Fix openshift oc cluster up mount openshift: Fix binary paths for oc cluster up to work Apr 3, 2018
@matthewbauer matthewbauer merged commit 0418f5e into NixOS:master Apr 17, 2018
@jensbin jensbin deleted the openshift_mount_fix branch April 17, 2018 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jensbin @matthewbauer @GrahamcOfBorg