Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ixgbevf: 4.3.3 -> 4.3.4 #38320

Merged
merged 1 commit into from Apr 2, 2018
Merged

ixgbevf: 4.3.3 -> 4.3.4 #38320

merged 1 commit into from Apr 2, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Apr 2, 2018

Motivation for this change

4.3.3 didn't build with linux 4.15.
ZHF #36453

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@xeji
ixgbevf: 4.3.3 -> 4.3.4
cb113dd 
4.3.3 didn't build with linux 4.15
@thoughtpolice
Copy link
Member

Tested, thanks. This will knock out a few failures!

@thoughtpolice thoughtpolice merged commit a743509 into NixOS:master Apr 2, 2018
@thoughtpolice
Copy link
Member

Merged to release-18.03 as well.

@xeji xeji deleted the p/ixgbevf branch April 2, 2018 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xeji @thoughtpolice @GrahamcOfBorg