Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve debug edid help and error #424

Merged
merged 1 commit into from Jul 21, 2018
Merged

Conversation

shivmgg
Copy link
Contributor

@shivmgg shivmgg commented Apr 1, 2018

I think #418 can be resolved by the following commit.

@CarlFK
Copy link
Contributor

CarlFK commented Apr 1, 2018

#418 isn't fully resolved, but this is a step in the right direction. It does make things better.

I think.

I'll have to admit I'm having trouble envisioning the details, but here are my thoughts:

I don't think the new error message is better. It still seems misleading.

H2U 00:17:45>debug edid o0
no such port
H2U 00:17:45>debug edid input0
no such port
H2U 00:17:45>debug edid foo
no such port

the first one should not error :p
input0 and foo should have different error messages. maybe.
"invalid parameter" might be better. It doesn't tell me anything new, but maybe it doesn't mislead me.

I am also not sure how much value there is for this.

@shivmgg
Copy link
Contributor Author

shivmgg commented Apr 2, 2018

@CarlFK As far as I can understand, error log can be divided into the following sub-cases:

H2U 00:17:45>debug edid o0
o0 has no EDID capabilities.
H2U 00:17:45>debug edid input0
input0 is not an output port.
H2U 00:17:45>debug edid foo
invalid parameter
H2U 00:17:45>debug edid output1
no error message(in case output1 has EDID capabilities.)

Am I correct?

@CarlFK
Copy link
Contributor

CarlFK commented Apr 2, 2018

kinda.
Not sure that calling them categories helps.

This is a bug:

H2U 00:17:45>debug edid o0
o0 has no EDID capabilities.

These two are similar:

input0 is not an output port.
H2U 00:17:45>debug edid foo
invalid parameter

and "no error" is also different.

otherwise... sure. ;)

adding more...
"foo is not an output port"

What makes things confusing is the input/output terms are kinda backwards in this case. "output 0" sends hdmi data (so clearly output) but it receives edid data from the display device (so in this sense it is an input.) I am not saying we should relabel the ports, but saying or implying "input 0 is not a port" makes my brain hurt.

@mithro
Copy link
Member

mithro commented May 19, 2018

@shivmgg Hi! Could you make the changes requested by @CarlFK and then I can merge your pull request!

@shivmgg
Copy link
Contributor Author

shivmgg commented May 21, 2018

Hi, I got a little busy with OpenSoCDebug Project. I will update it by tomorrow.

@mithro mithro changed the title update-debug-edid help and error Improve debug edid help and error Jul 21, 2018
@mithro mithro merged commit 1dd89e6 into timvideos:master Jul 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants