Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

znc: add uriPrefix option #38324

Merged
merged 1 commit into from Jul 10, 2018
Merged

znc: add uriPrefix option #38324

merged 1 commit into from Jul 10, 2018

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Apr 2, 2018

Motivation for this change

Allows the ZNC web interface to be hosted behind a reverse proxy as a subdirectory.

https://wiki.znc.in/Reverse_Proxy#As_subdirectory

Could this also be cherry-picked to the release-18.03 branch please?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested on my server.
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@rvl
znc: add uriPrefix option
d06b547 
Allows the ZNC web interface to be hosted behind a reverse proxy as a
subdirectory.

https://wiki.znc.in/Reverse_Proxy#As_subdirectory
infinisil
infinisil approved these changes Apr 8, 2018
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I also have a couple patches to the ZNC module in my own nixpkgs. I think eventually this module should be rewritten such that you can customize it arbitrarily. The current one is super limited :/

@xeji xeji merged commit 51d0309 into NixOS:master Jul 10, 2018
@infinisil
Copy link
Member

I probably should have mentioned my #41467 here, oh well. When that PR is merged there will be a lot less need for ZNC PRs adding options.

@rvl
Copy link
Contributor Author

rvl commented Jul 12, 2018

Thanks @xeji.
That PR looks interesting, thanks @infinisil

@rvl rvl deleted the znc-uri-prefix branch July 12, 2018 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rvl @infinisil @GrahamcOfBorg @xeji