react-native-debugger: init at 0.7.18 #38327
Conversation
|
Success on x86_64-linux (full log) Attempted: react-native-debugger Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: react-native-debugger Partial log (click to expand)
|
| unzip $src -d $out | ||
|
|
||
| mkdir $out/{lib,bin,share} | ||
| mv $out/lib{node,ffmpeg}.so $out/lib |
There was a problem hiding this comment.
Looks like the tarball bundles libnode.so and libffmpeg.so as binaries. Shoulnd't we use nixpkgs versions instead?
There was a problem hiding this comment.
Not sure though. I need a second, closer look at the prebuilt package as it could be possible that they're using some kind of modified shared objects
There was a problem hiding this comment.
Might not be worth much effort since the main binary is a blob anyway.
Have you ever tried to build this from source?
There was a problem hiding this comment.
No, unfortunately not. This is a package I currently need for some projects and I wanted to file a patch with the expression I originally added to my personal overlay.
The thing is, building from source would require way more effort ATM as we would some kind of builder for electron apps first and regarding such a feature there are currently pending discussions in #26698, #17073 and this project: https://github.com/NixOS/nixpkgs/projects/6
As I don't think I'm sufficiently qualified for this job (and I don't think that I'll have enough time in the next months) I didn't work on this, however I'd rewrite the expression in case we have such a feature.
Ma27
force-pushed
the
package-react-native-debugger
branch
from
ac92d09
to
f43b40a
Compare
|
Success on x86_64-linux (full log) Attempted: react-native-debugger Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: react-native-debugger Partial log (click to expand)
|
Ma27
force-pushed
the
package-react-native-debugger
branch
from
bc90af8
to
767f4fe
Compare
|
Success on x86_64-linux (full log) Attempted: react-native-debugger Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: react-native-debugger Partial log (click to expand)
|
|
ok, just did some research: first of all it seems as especially the shared objects The same can be observed with However I'm clearly aware that in the end a build from source might be the better solution, however this requires some more significant changes in nixpkgs I won't have time to develop/maintain ATM, but in case we build electron apps from source some day (see the issues I linked above), I'd offer to rewrite this derivation accordingly %) |
|
is there anything else to be discussed? Otherwise I'd love to see this merged :) |
Motivation for this change
Electron application that can be used to debug React Native applications.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)