Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dwarf-fortress: Provide package with plugins #38313

Closed
wants to merge 1 commit into from

Conversation

mkaito
Copy link
Contributor

@mkaito mkaito commented Apr 1, 2018

This package calls the existing wrapper enabling all available plugins:

  • DFHack
  • SoundSense
  • StoneSense
Motivation for this change

To provide a package for dwarf fortress that enables the above plugins.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

This package calls the existing wrapper enabling all available plugins:

* DFHack
* SoundSense
* StoneSense

Fixes NixOS#38307
@mkaito
Copy link
Contributor Author

mkaito commented Apr 2, 2018

The resulting attribute name dwarf-fortress-packages.hacked is arguably not ideal. Suggestions welcome.

There could also be a point made that one should just dwarf-fortress-packages.dwarf-fortress.override { enableDFHack = true; } instead, but I think this is convenient and adds little overhead. Also, using overrides like this is non-obvious, at least to me.

@matthewbauer
Copy link
Member

Thank for the contribution, but this is just too specific for us to support. You can always accomplish this with a package override (https://nixos.org/nixpkgs/manual/#sec-modify-via-packageOverrides):

{
  packageOverrides = pkgs: {
    dwarf-fortress = pkgs.dwarf-fortress-packages.dwarf-fortress.overrideAttrs (o: {
      enableDFHack = true;
      enableSoundSense = true;
      enableStoneSense = true;
      themes = {
        "phoebus" = pkgs.dwarf-fortress-packages.phoebus-theme;
        "cla" = pkgs.dwarf-fortress-packages.cla-theme;
      };
    });
  };
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants