Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zsh: 5.4.2 -> 5.5 #38652

Merged
merged 1 commit into from Apr 9, 2018
Merged

zsh: 5.4.2 -> 5.5 #38652

merged 1 commit into from Apr 9, 2018

Conversation

hedning
Copy link
Contributor

@hedning hedning commented Apr 9, 2018

Motivation for this change

New stable release of ZSH: https://sourceforge.net/p/zsh/code/ci/master/tree/

Things done

Using it on my NixOS setup now without any obvious problems.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Apr 9, 2018

@GrahamcOfBorg build zsh

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: zsh

Partial log (click to expand)

shrinking /nix/store/k3zg9hm6w0xwj5rgkcmpjv9767f34qmd-zsh-5.5/lib/zsh/5.5/zsh/pcre.so
shrinking /nix/store/k3zg9hm6w0xwj5rgkcmpjv9767f34qmd-zsh-5.5/lib/zsh/5.5/zsh/system.so
shrinking /nix/store/k3zg9hm6w0xwj5rgkcmpjv9767f34qmd-zsh-5.5/lib/zsh/5.5/zsh/compctl.so
gzipping man pages under /nix/store/k3zg9hm6w0xwj5rgkcmpjv9767f34qmd-zsh-5.5/share/man/
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/k3zg9hm6w0xwj5rgkcmpjv9767f34qmd-zsh-5.5/lib  /nix/store/k3zg9hm6w0xwj5rgkcmpjv9767f34qmd-zsh-5.5/bin
patching script interpreter paths in /nix/store/k3zg9hm6w0xwj5rgkcmpjv9767f34qmd-zsh-5.5
/nix/store/k3zg9hm6w0xwj5rgkcmpjv9767f34qmd-zsh-5.5/share/zsh/5.5/functions/harden: interpreter directive changed from "/bin/sh" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/sh"
checking for references to /tmp/nix-build-zsh-5.5.drv-0 in /nix/store/k3zg9hm6w0xwj5rgkcmpjv9767f34qmd-zsh-5.5...
/nix/store/k3zg9hm6w0xwj5rgkcmpjv9767f34qmd-zsh-5.5

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: zsh

Partial log (click to expand)

fi
mkdir -m 755 -p -- /nix/store/nxrbq21fvlpma1ii614a02hwza88ffp0-zsh-5.5/share/zsh/5.5/help
make[1]: Leaving directory '/private/tmp/nix-build-zsh-5.5.drv-0/zsh-5.5/Doc'
post-installation fixup
gzipping man pages under /nix/store/nxrbq21fvlpma1ii614a02hwza88ffp0-zsh-5.5/share/man/
strip is /nix/store/0fzpxnsanc02i4jsb1yhchjp4p62b2n3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/nxrbq21fvlpma1ii614a02hwza88ffp0-zsh-5.5/lib  /nix/store/nxrbq21fvlpma1ii614a02hwza88ffp0-zsh-5.5/bin
patching script interpreter paths in /nix/store/nxrbq21fvlpma1ii614a02hwza88ffp0-zsh-5.5
/nix/store/nxrbq21fvlpma1ii614a02hwza88ffp0-zsh-5.5/share/zsh/5.5/functions/harden: interpreter directive changed from "/bin/sh" to "/nix/store/x030a63qdilnv02pkivfjg44pdxsh5km-bash-4.4-p19/bin/sh"
/nix/store/nxrbq21fvlpma1ii614a02hwza88ffp0-zsh-5.5

@Mic92
Copy link
Member

Mic92 commented Apr 9, 2018 

Changes from 5.4.2 to 5.5
-------------------------

The effect of the NO_INTERACTIVE_COMMENTS option extends into $(...) and
`...` command substitutions when used on the command line.  Previously,
comments were always recognized within command substitutions unless the
comment character "#" was disabled via reset of $histchars.

An alternative assignment syntax for indicating indices for arrays
and keys for associative arrays:

typeset -a array=([1]=first [2]=second)
typeset -A assoc=([key1]=val1 [key2]=val2)

is allowed for compatibility with other shells.  In the case of normal
arrays the new syntax can be mixed with the old.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: zsh

Partial log (click to expand)

shrinking /nix/store/49lpizw250qhj5yrxr4kkc48z2mfk4n3-zsh-5.5/lib/zsh/5.5/zsh/rlimits.so
shrinking /nix/store/49lpizw250qhj5yrxr4kkc48z2mfk4n3-zsh-5.5/bin/zsh
shrinking /nix/store/49lpizw250qhj5yrxr4kkc48z2mfk4n3-zsh-5.5/bin/zsh-5.5
gzipping man pages under /nix/store/49lpizw250qhj5yrxr4kkc48z2mfk4n3-zsh-5.5/share/man/
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/49lpizw250qhj5yrxr4kkc48z2mfk4n3-zsh-5.5/lib  /nix/store/49lpizw250qhj5yrxr4kkc48z2mfk4n3-zsh-5.5/bin
patching script interpreter paths in /nix/store/49lpizw250qhj5yrxr4kkc48z2mfk4n3-zsh-5.5
/nix/store/49lpizw250qhj5yrxr4kkc48z2mfk4n3-zsh-5.5/share/zsh/5.5/functions/harden: interpreter directive changed from "/bin/sh" to "/nix/store/3gg2p6n4kv2f0lsxd41f5iz1ivkbzyzr-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/49lpizw250qhj5yrxr4kkc48z2mfk4n3-zsh-5.5...
/nix/store/49lpizw250qhj5yrxr4kkc48z2mfk4n3-zsh-5.5

@Mic92 Mic92 merged commit e357eb0 into NixOS:master Apr 9, 2018
@hedning hedning deleted the zsh-5.5 branch April 9, 2018 19:53
@oxij
Copy link
Member

oxij commented Apr 11, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hedning @Mic92 @GrahamcOfBorg @oxij