Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsdist: init at 1.3.0 #38658

Merged
merged 1 commit into from Apr 21, 2018
Merged

dnsdist: init at 1.3.0 #38658

merged 1 commit into from Apr 21, 2018

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented Apr 9, 2018

Motivation for this change

nix(os) was lacking dnsdist

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Mic92
Mic92 reviewed Apr 10, 2018
View reviewed changes
pkgs/servers/dns/dnsdist/default.nix
meta = with stdenv.lib; {
description = "DNS Loadbalancer";
homepage = "https://dnsdist.org";
license = licenses.gpl2;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to maintain this? https://nixos.wiki/wiki/Nixpkgs#Becoming_a_Nixpkgs_maintainer

@Mic92
Copy link
Member

Mic92 commented Apr 10, 2018

@GrahamcOfBorg build dnsdist

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: dnsdist

Partial log (click to expand)

Cannot nix-instantiate `dnsdist' because:
�[31;1merror:�[0m while evaluating the attribute 'buildInputs' of the derivation 'dnsdist-1.3.0' at �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/stdenv/generic/make-derivation.nix�[0m:148:11:
while evaluating 'getOutput' at �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/attrsets.nix�[0m:450:23, called from undefined position:
while evaluating anonymous function at �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/stdenv/generic/make-derivation.nix�[0m:97:17, called from undefined position:
while evaluating 'callPackageWith' at �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix�[0m:113:35, called from �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/top-level/all-packages.nix�[0m:14001:13:
while evaluating 'makeOverridable' at �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix�[0m:72:24, called from �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix�[0m:117:8:
while evaluating anonymous function at �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/systemd/default.nix�[0m:1:1, called from �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix�[0m:74:12:
assertion failed at �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/systemd/default.nix�[0m:16:1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: dnsdist

Partial log (click to expand)

make[1]: Leaving directory '/build/dnsdist-1.3.0'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/znl8ygsil7hbk2w1xg01idi82vp18r05-dnsdist-1.3.0
shrinking /nix/store/znl8ygsil7hbk2w1xg01idi82vp18r05-dnsdist-1.3.0/bin/dnsdist
gzipping man pages under /nix/store/znl8ygsil7hbk2w1xg01idi82vp18r05-dnsdist-1.3.0/share/man/
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/znl8ygsil7hbk2w1xg01idi82vp18r05-dnsdist-1.3.0/lib  /nix/store/znl8ygsil7hbk2w1xg01idi82vp18r05-dnsdist-1.3.0/bin
patching script interpreter paths in /nix/store/znl8ygsil7hbk2w1xg01idi82vp18r05-dnsdist-1.3.0
checking for references to /build in /nix/store/znl8ygsil7hbk2w1xg01idi82vp18r05-dnsdist-1.3.0...
/nix/store/znl8ygsil7hbk2w1xg01idi82vp18r05-dnsdist-1.3.0

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: dnsdist

Partial log (click to expand)

make[4]: Leaving directory '/build/dnsdist-1.3.0'
make[3]: *** [Makefile:1439: check-TESTS] Error 2
make[3]: Leaving directory '/build/dnsdist-1.3.0'
make[2]: *** [Makefile:1667: check-am] Error 2
make[2]: Leaving directory '/build/dnsdist-1.3.0'
make[1]: *** [Makefile:1216: check-recursive] Error 1
make[1]: Leaving directory '/build/dnsdist-1.3.0'
make: *** [Makefile:1669: check] Error 2
builder for '/nix/store/cn21xw0yy1al86np7dz1yyq6k0a5z9ss-dnsdist-1.3.0.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/cn21xw0yy1al86np7dz1yyq6k0a5z9ss-dnsdist-1.3.0.drv' failed

@joachifm joachifm merged commit 17b73ff into NixOS:master Apr 21, 2018
@joachifm
Copy link
Contributor

Thank you.

@vcunat vcunat mentioned this pull request May 1, 2018
Merged
8 tasks
@dasJ dasJ deleted the dnsdist-pkg branch June 4, 2018 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dasJ @Mic92 @GrahamcOfBorg @joachifm @Janik-Haag