Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iaca: init at 3.0, 2.1 #38659

Merged
merged 3 commits into from Apr 10, 2018
Merged

iaca: init at 3.0, 2.1 #38659

merged 3 commits into from Apr 10, 2018

Conversation

kazcw
Copy link
Contributor

@kazcw kazcw commented Apr 9, 2018

Motivation for this change

Add packages for IACA (Intel Architecture Code Analyzer).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

with stdenv.lib;

stdenv.mkDerivation {
name = "iaca-2.1";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this particular version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.1 is the last version to support NHM/WSM arches; 3.0 has everything else.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this add as a comment. Otherwise people might remove this version at some point.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, how's this? (50dee8d)

description = "Intel Architecture Code Analyzer";
homepage = https://software.intel.com/en-us/articles/intel-architecture-code-analyzer/;
license = licenses.unfree;
platforms = [ "x86_64-linux" ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

description = "Intel Architecture Code Analyzer";
homepage = https://software.intel.com/en-us/articles/intel-architecture-code-analyzer/;
license = licenses.unfree;
platforms = [ "x86_64-linux" ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do that

@Mic92 Mic92 merged commit 87fd6c1 into NixOS:master Apr 10, 2018
@Mic92
Copy link
Member

Mic92 commented Apr 10, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants