Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

musl: enable musl-gcc, ld.musl-clang, musl-clang #38651

Merged
merged 1 commit into from Apr 10, 2018
Merged

musl: enable musl-gcc, ld.musl-clang, musl-clang #38651

merged 1 commit into from Apr 10, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Apr 9, 2018 •
edited

These are convenient for projects with mixed musl/glibc build targets.
For pure musl builds in nixpkgs, we probably want a musl stdenv.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
musl: enable musl-gcc, ld.musl-clang, musl-clang
654ce4b 
These are convenient for projects with mixed musl/glibc build targets.
For pure musl builds in nixpkgs, we probably want a musl stdenv.
@Mic92 Mic92 requested a review from dtzWill April 9, 2018 15:13
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: musl

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/nxxjsl5mylvq18760q6vwc1zbwa0r95r-musl-1.1.19-dev
patching script interpreter paths in /nix/store/nxxjsl5mylvq18760q6vwc1zbwa0r95r-musl-1.1.19-dev
/nix/store/nxxjsl5mylvq18760q6vwc1zbwa0r95r-musl-1.1.19-dev/bin/ld.musl-clang: interpreter directive changed from "/bin/sh" to "/nix/store/3gg2p6n4kv2f0lsxd41f5iz1ivkbzyzr-bash-4.4-p19/bin/sh"
/nix/store/nxxjsl5mylvq18760q6vwc1zbwa0r95r-musl-1.1.19-dev/bin/musl-clang: interpreter directive changed from "/bin/sh" to "/nix/store/3gg2p6n4kv2f0lsxd41f5iz1ivkbzyzr-bash-4.4-p19/bin/sh"
/nix/store/nxxjsl5mylvq18760q6vwc1zbwa0r95r-musl-1.1.19-dev/bin/musl-gcc: interpreter directive changed from "/bin/sh" to "/nix/store/3gg2p6n4kv2f0lsxd41f5iz1ivkbzyzr-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/nxxjsl5mylvq18760q6vwc1zbwa0r95r-musl-1.1.19-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/027bdnw4jfzbnly85p1zkrwb6n2pl7yc-musl-1.1.19-debug
patching script interpreter paths in /nix/store/027bdnw4jfzbnly85p1zkrwb6n2pl7yc-musl-1.1.19-debug
checking for references to /build in /nix/store/027bdnw4jfzbnly85p1zkrwb6n2pl7yc-musl-1.1.19-debug...
/nix/store/yjxqi1vvz4lgvrysbwx0v95ykycfwqcr-musl-1.1.19

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: musl

Partial log (click to expand)

Cannot nix-instantiate `musl' because:
�[31;1merror:�[0m while evaluating 'callPackageWith' at �[1m/private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix�[0m:113:35, called from �[1m/private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/top-level/all-packages.nix�[0m:13760:10:
while evaluating 'makeOverridable' at �[1m/private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix�[0m:72:24, called from �[1m/private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix�[0m:117:8:
while evaluating anonymous function at �[1m/private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/musl/default.nix�[0m:1:1, called from �[1m/private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix�[0m:74:12:
while evaluating 'mkDerivation' at �[1m/private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/stdenv/generic/make-derivation.nix�[0m:15:5, called from �[1m/private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/musl/default.nix�[0m:21:1:
while evaluating 'extendDerivation' at �[1m/private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix�[0m:135:43, called from �[1m/private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/stdenv/generic/make-derivation.nix�[0m:248:7:
while evaluating 'optionalAttrs' at �[1m/private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/attrsets.nix�[0m:321:25, called from �[1m/private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/stdenv/generic/make-derivation.nix�[0m:196:14:
assertion failed at �[1m/private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/stdenv/generic/make-derivation.nix�[0m:120:36

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: musl

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/76na9nnjj52wn9dkpmsr8w0s3mjb4wma-musl-1.1.19-dev
patching script interpreter paths in /nix/store/76na9nnjj52wn9dkpmsr8w0s3mjb4wma-musl-1.1.19-dev
/nix/store/76na9nnjj52wn9dkpmsr8w0s3mjb4wma-musl-1.1.19-dev/bin/musl-gcc: interpreter directive changed from "/bin/sh" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/sh"
/nix/store/76na9nnjj52wn9dkpmsr8w0s3mjb4wma-musl-1.1.19-dev/bin/musl-clang: interpreter directive changed from "/bin/sh" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/sh"
/nix/store/76na9nnjj52wn9dkpmsr8w0s3mjb4wma-musl-1.1.19-dev/bin/ld.musl-clang: interpreter directive changed from "/bin/sh" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/76na9nnjj52wn9dkpmsr8w0s3mjb4wma-musl-1.1.19-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/kq5r4g4fgshy3ird3k0gsf1pmngyy460-musl-1.1.19-debug
patching script interpreter paths in /nix/store/kq5r4g4fgshy3ird3k0gsf1pmngyy460-musl-1.1.19-debug
checking for references to /build in /nix/store/kq5r4g4fgshy3ird3k0gsf1pmngyy460-musl-1.1.19-debug...
/nix/store/hbdbq889c7wixj0rzwp47j506hkrwk2w-musl-1.1.19

@Mic92 Mic92 merged commit daa1741 into NixOS:master Apr 10, 2018
@Mic92 Mic92 deleted the musl-gcc branch April 10, 2018 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzWill dtzWill Awaiting requested review from dtzWill

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @GrahamcOfBorg