Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testssl: 2.9.5-3 -> 2.9.5-4 #38654

Merged
merged 1 commit into from Apr 9, 2018
Merged

testssl: 2.9.5-3 -> 2.9.5-4 #38654

merged 1 commit into from Apr 9, 2018

Conversation

etu
Copy link
Contributor

@etu etu commented Apr 9, 2018

Motivation for this change

Changelog:
https://github.com/drwetter/testssl.sh/releases/tag/v2.9.5-4

Also improved the expression to be more readable.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@etu
testssl: 2.9.5-3 -> 2.9.5-4
7b4ed22 
Changelog:
https://github.com/drwetter/testssl.sh/releases/tag/v2.9.5-4

Also improved the expression to be more readable.
@Mic92
Copy link
Member

Mic92 commented Apr 9, 2018

@GrahamcOfBorg build testssl

@Mic92
Copy link
Member

Mic92 commented Apr 9, 2018

@etu can you also apply for borg access? NixOS/ofborg#151

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: testssl

Partial log (click to expand)

no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/fai7dix91qb9gw6fccmlm28v0a3z1qv4-testssl.sh-2.9.5-4
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/fai7dix91qb9gw6fccmlm28v0a3z1qv4-testssl.sh-2.9.5-4/bin
patching script interpreter paths in /nix/store/fai7dix91qb9gw6fccmlm28v0a3z1qv4-testssl.sh-2.9.5-4
/nix/store/fai7dix91qb9gw6fccmlm28v0a3z1qv4-testssl.sh-2.9.5-4/bin/testssl.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/fai7dix91qb9gw6fccmlm28v0a3z1qv4-testssl.sh-2.9.5-4...
/nix/store/fai7dix91qb9gw6fccmlm28v0a3z1qv4-testssl.sh-2.9.5-4

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: testssl

Partial log (click to expand)

no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/7vlf91gxizsmf3yhgxswp0g3ln3kinc9-testssl.sh-2.9.5-4
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/7vlf91gxizsmf3yhgxswp0g3ln3kinc9-testssl.sh-2.9.5-4/bin
patching script interpreter paths in /nix/store/7vlf91gxizsmf3yhgxswp0g3ln3kinc9-testssl.sh-2.9.5-4
/nix/store/7vlf91gxizsmf3yhgxswp0g3ln3kinc9-testssl.sh-2.9.5-4/bin/testssl.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/3gg2p6n4kv2f0lsxd41f5iz1ivkbzyzr-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/7vlf91gxizsmf3yhgxswp0g3ln3kinc9-testssl.sh-2.9.5-4...
/nix/store/7vlf91gxizsmf3yhgxswp0g3ln3kinc9-testssl.sh-2.9.5-4

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: testssl

Partial log (click to expand)

no configure script, doing nothing
building
no Makefile, doing nothing
installing
post-installation fixup
strip is /nix/store/0fzpxnsanc02i4jsb1yhchjp4p62b2n3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/mbxdpd2yvsbkkhgl2b6ljr3f0agjirhq-testssl.sh-2.9.5-4/bin
patching script interpreter paths in /nix/store/mbxdpd2yvsbkkhgl2b6ljr3f0agjirhq-testssl.sh-2.9.5-4
/nix/store/mbxdpd2yvsbkkhgl2b6ljr3f0agjirhq-testssl.sh-2.9.5-4/bin/testssl.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/x030a63qdilnv02pkivfjg44pdxsh5km-bash-4.4-p19/bin/bash"
/nix/store/mbxdpd2yvsbkkhgl2b6ljr3f0agjirhq-testssl.sh-2.9.5-4

@Mic92 Mic92 merged commit 43a3cfe into NixOS:master Apr 9, 2018
@etu etu mentioned this pull request Apr 9, 2018
Merged
@etu etu deleted the testssl-update branch April 9, 2018 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@etu @Mic92 @GrahamcOfBorg