altcoins.mist: init at 0.10.0 #38661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jbboehr Could you squash the fix of the hash together with the init commit? |
jbboehr
force-pushed
the
ethereum-mist-browser-master
branch
from
0b44892
to
7cb50de
Compare
|
@etu Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Having an available package for the Ethereum Mist browser.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)At first I attempted to package it using node2nix, however ran into some issues. Currently, it is using the binary releases, patching the ELF, but it still needs to run inside an FHS user env because the program attempts to download the
gethbinary to the home directory, which is linked to the standard/usr/libpaths. Specifying a geth binary is currently not working [1] [2].I've tested it on my system running 18.03 with Gnome 3.
It should be possible to add a Mac build as well, but I do not have a Mac available to test and so did not.
I did not add myself as a maintainer because I'm not sure if I'll be able to maintain it going forward. Please let me know how to proceed, if I should add it anyway or if someone else is interested in adopting it.