Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodePackages_8_x.re-natal: init at 0.8.2 #37701

Closed
wants to merge 1 commit into from
Closed

nodePackages_8_x.re-natal: init at 0.8.2 #37701

wants to merge 1 commit into from

Conversation

peterromfeldhk
Copy link
Contributor

@peterromfeldhk peterromfeldhk commented Mar 23, 2018 •
edited

nodePackages_8_x.re-natal: init at 0.8.2
nodePackages_8_x.react-native-cli: init at 2.0.1

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@peterromfeldhk
nodePackages_8_x.re-natal: init at 0.8.2
029cffd 
nodePackages_8_x.react-native-cli init at 2.0.1
Mic92
Mic92 reviewed Mar 25, 2018
View reviewed changes
pkgs/development/node-packages/node-packages-v8.json
@@ -9,6 +9,8 @@
, "node-gyp-build"
, "node-pre-gyp"
, "pnpm"
, "react-native-cli"
, "re-natal"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

$ find /nix/store/ikqc7gc5ipq9jr5lharfsqpix5754003-node-re-natal-0.8.2/bin

contains no files, how is it supposed to be used?

@Mic92
Copy link
Member

Mic92 commented Mar 25, 2018

@GrahamcOfBorg build nodePackages_8_x.re-natal

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: nodePackages_8_x.re-natal

Partial log (click to expand)

window-size@0.1.0 /nix/store/iz732d9ljs0iz9zqlrpzm0rbq81i58jp-node-re-natal-0.8.2/lib/node_modules/re-natal/node_modules/window-size
yargs@3.10.0 /nix/store/iz732d9ljs0iz9zqlrpzm0rbq81i58jp-node-re-natal-0.8.2/lib/node_modules/re-natal/node_modules/yargs
uglify-js@2.8.29 /nix/store/iz732d9ljs0iz9zqlrpzm0rbq81i58jp-node-re-natal-0.8.2/lib/node_modules/re-natal/node_modules/uglify-js
source-map@0.5.7 /nix/store/iz732d9ljs0iz9zqlrpzm0rbq81i58jp-node-re-natal-0.8.2/lib/node_modules/re-natal/node_modules/uglify-js/node_modules/source-map
removed 1 package in 0.975s
post-installation fixup
patching script interpreter paths in /nix/store/iz732d9ljs0iz9zqlrpzm0rbq81i58jp-node-re-natal-0.8.2
/nix/store/iz732d9ljs0iz9zqlrpzm0rbq81i58jp-node-re-natal-0.8.2/lib/node_modules/re-natal/node_modules/atob/bin/atob.js: interpreter directive changed from "/usr/bin/env node" to "/nix/store/w1in3cjcqlxkf35y6bd3wk7zw58dnlw8-nodejs-8.10.0/bin/node"
/nix/store/iz732d9ljs0iz9zqlrpzm0rbq81i58jp-node-re-natal-0.8.2/lib/node_modules/re-natal/node_modules/uglify-js/bin/uglifyjs: interpreter directive changed from " /usr/bin/env node" to "/nix/store/w1in3cjcqlxkf35y6bd3wk7zw58dnlw8-nodejs-8.10.0/bin/node"
/nix/store/iz732d9ljs0iz9zqlrpzm0rbq81i58jp-node-re-natal-0.8.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nodePackages_8_x.re-natal

Partial log (click to expand)

uglify-js@2.8.29 /nix/store/ikqc7gc5ipq9jr5lharfsqpix5754003-node-re-natal-0.8.2/lib/node_modules/re-natal/node_modules/uglify-js
source-map@0.5.7 /nix/store/ikqc7gc5ipq9jr5lharfsqpix5754003-node-re-natal-0.8.2/lib/node_modules/re-natal/node_modules/uglify-js/node_modules/source-map
removed 1 package in 2.644s
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ikqc7gc5ipq9jr5lharfsqpix5754003-node-re-natal-0.8.2
patching script interpreter paths in /nix/store/ikqc7gc5ipq9jr5lharfsqpix5754003-node-re-natal-0.8.2
/nix/store/ikqc7gc5ipq9jr5lharfsqpix5754003-node-re-natal-0.8.2/lib/node_modules/re-natal/node_modules/atob/bin/atob.js: interpreter directive changed from "/usr/bin/env node" to "/nix/store/7nvanx63589pmh40bzz7yiiwms0fn0ja-nodejs-8.10.0/bin/node"
/nix/store/ikqc7gc5ipq9jr5lharfsqpix5754003-node-re-natal-0.8.2/lib/node_modules/re-natal/node_modules/uglify-js/bin/uglifyjs: interpreter directive changed from " /usr/bin/env node" to "/nix/store/7nvanx63589pmh40bzz7yiiwms0fn0ja-nodejs-8.10.0/bin/node"
checking for references to /build in /nix/store/ikqc7gc5ipq9jr5lharfsqpix5754003-node-re-natal-0.8.2...
/nix/store/ikqc7gc5ipq9jr5lharfsqpix5754003-node-re-natal-0.8.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nodePackages_8_x.re-natal

Partial log (click to expand)

uglify-js@2.8.29 /nix/store/z5809jdfdsip6wjw5i3mlj68yhkyjysm-node-re-natal-0.8.2/lib/node_modules/re-natal/node_modules/uglify-js
source-map@0.5.7 /nix/store/z5809jdfdsip6wjw5i3mlj68yhkyjysm-node-re-natal-0.8.2/lib/node_modules/re-natal/node_modules/uglify-js/node_modules/source-map
removed 1 package in 3.857s
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/z5809jdfdsip6wjw5i3mlj68yhkyjysm-node-re-natal-0.8.2
patching script interpreter paths in /nix/store/z5809jdfdsip6wjw5i3mlj68yhkyjysm-node-re-natal-0.8.2
/nix/store/z5809jdfdsip6wjw5i3mlj68yhkyjysm-node-re-natal-0.8.2/lib/node_modules/re-natal/node_modules/uglify-js/bin/uglifyjs: interpreter directive changed from " /usr/bin/env node" to "/nix/store/pid5prbhbx5qrcx0q2fwh5dw1xvjwj5k-nodejs-8.10.0/bin/node"
/nix/store/z5809jdfdsip6wjw5i3mlj68yhkyjysm-node-re-natal-0.8.2/lib/node_modules/re-natal/node_modules/atob/bin/atob.js: interpreter directive changed from "/usr/bin/env node" to "/nix/store/pid5prbhbx5qrcx0q2fwh5dw1xvjwj5k-nodejs-8.10.0/bin/node"
checking for references to /build in /nix/store/z5809jdfdsip6wjw5i3mlj68yhkyjysm-node-re-natal-0.8.2...
/nix/store/z5809jdfdsip6wjw5i3mlj68yhkyjysm-node-re-natal-0.8.2

@adisbladis
Copy link
Member

There are a few dependencies of re-natal that should be wrapped/passed as buildInputs.

https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/node-packages/default-v8.nix

@Mic92
Copy link
Member

Mic92 commented Nov 9, 2018

Outdated. Please open a new pull request if you are still interested.

@Mic92 Mic92 closed this Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
6.topic: nodejs 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@peterromfeldhk @Mic92 @GrahamcOfBorg @adisbladis @matthewbauer