Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.09] firefox updates (59.0 -> 59.0.1, firefox-esr: 52.7.1esr -> 52.7.2esr) #37313

Merged
merged 4 commits into from Mar 20, 2018
Merged

[17.09] firefox updates (59.0 -> 59.0.1, firefox-esr: 52.7.1esr -> 52.7.2esr) #37313

merged 4 commits into from Mar 20, 2018

Conversation

andir
Copy link
Member

@andir andir commented Mar 18, 2018 •
edited

Motivation for this change

Backport of #37208

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@andir
Copy link
Member Author

andir commented Mar 18, 2018

Updated the commit messages to reflect the actual changes.

@andir andir mentioned this pull request Mar 18, 2018
Merged
8 tasks
@vcunat
Copy link
Member

vcunat commented Mar 18, 2018

59 needs rustc update, apparently.

@vcunat
Copy link
Member

vcunat commented Mar 18, 2018

I pushed the ESR part at least.

andir and others added 3 commits March 18, 2018 21:51
@andir
rust121bin: 1.21.0 -> 1.24.0
30e84fa 
also renamed to rust124bin
@taku0 @andir
firefox-bin: 59.0 -> 59.0.1
3b34504 
(cherry picked from commit 3d28c32)
@taku0 @andir
firefox: 58.0.2 -> 59.0.1
a8c8d06 
(cherry picked from commit 9aae5d7)
@andir
Copy link
Member Author

andir commented Mar 18, 2018

I did bump the rust version beyond the actual requirement as per Rust Update Policy for Firefox we will need 1.24.0 next month if we intend to keep firefox updated for another round on 17.09. Who knows what kind of (security) issues might show up..

@ryantm @andir
nspr: 4.17 -> 4.18
193e474 
Semi-automatic update. These checks were performed:

- built on NixOS
- found 4.18 with grep in /nix/store/23322yndj5lh6n4pr3maj26irnwklq31-nspr-4.18
- found 4.18 in filename of file in /nix/store/23322yndj5lh6n4pr3maj26irnwklq31-nspr-4.18

(cherry picked from commit 52b2e79)
We would probably have to pick it soon anyway, due to Firefox updates.
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nspr

Partial log (click to expand)

shrinking /nix/store/4mlw3ap5hhfhs48azaw7dylg0n9gyynx-nspr-4.18/lib/libplc4.so
stripping (with flags -S) in /nix/store/4mlw3ap5hhfhs48azaw7dylg0n9gyynx-nspr-4.18/lib
patching script interpreter paths in /nix/store/4mlw3ap5hhfhs48azaw7dylg0n9gyynx-nspr-4.18
checking for references to /build in /nix/store/4mlw3ap5hhfhs48azaw7dylg0n9gyynx-nspr-4.18...
shrinking RPATHs of ELF executables and libraries in /nix/store/yl7qw492zf5qwsr1ayfx8f43q6c60qi7-nspr-4.18-dev
stripping (with flags -S) in /nix/store/yl7qw492zf5qwsr1ayfx8f43q6c60qi7-nspr-4.18-dev/lib  /nix/store/yl7qw492zf5qwsr1ayfx8f43q6c60qi7-nspr-4.18-dev/bin
patching script interpreter paths in /nix/store/yl7qw492zf5qwsr1ayfx8f43q6c60qi7-nspr-4.18-dev
/nix/store/yl7qw492zf5qwsr1ayfx8f43q6c60qi7-nspr-4.18-dev/bin/nspr-config: interpreter directive changed from "/bin/sh" to "/nix/store/jgw8hxx7wzkyhb2dr9hwsd9h2caaasdc-bash-4.4-p12/bin/sh"
checking for references to /build in /nix/store/yl7qw492zf5qwsr1ayfx8f43q6c60qi7-nspr-4.18-dev...
/nix/store/4mlw3ap5hhfhs48azaw7dylg0n9gyynx-nspr-4.18

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: nspr

Partial log (click to expand)

/nix/store/6lzlinvlkgvpxgyrhn29sbgi0c23m53k-nspr-4.18/lib/libplds4.dylib: fixing dylib
/nix/store/6lzlinvlkgvpxgyrhn29sbgi0c23m53k-nspr-4.18/lib/libnspr4.dylib: fixing dylib
/nix/store/6lzlinvlkgvpxgyrhn29sbgi0c23m53k-nspr-4.18/lib/libplc4.dylib: fixing dylib
/nix/store/6lzlinvlkgvpxgyrhn29sbgi0c23m53k-nspr-4.18/lib/libplds4.dylib: fixing dylib
stripping (with flags -S) in /nix/store/6lzlinvlkgvpxgyrhn29sbgi0c23m53k-nspr-4.18/lib
patching script interpreter paths in /nix/store/6lzlinvlkgvpxgyrhn29sbgi0c23m53k-nspr-4.18
stripping (with flags -S) in /nix/store/18i9zcgfa3c0q3i04jp7ncsicdp9r2pr-nspr-4.18-dev/lib  /nix/store/18i9zcgfa3c0q3i04jp7ncsicdp9r2pr-nspr-4.18-dev/bin
patching script interpreter paths in /nix/store/18i9zcgfa3c0q3i04jp7ncsicdp9r2pr-nspr-4.18-dev
/nix/store/18i9zcgfa3c0q3i04jp7ncsicdp9r2pr-nspr-4.18-dev/bin/nspr-config: interpreter directive changed from "/bin/sh" to "/nix/store/03pdhzb1qlgn4jil6kbxy75dcqpd1m1a-bash-4.4-p12/bin/sh"
/nix/store/6lzlinvlkgvpxgyrhn29sbgi0c23m53k-nspr-4.18

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nspr

Partial log (click to expand)

shrinking /nix/store/7zs581l2vpk74wwfsi9qihwcbwfgan7w-nspr-4.18/lib/libnspr4.so
stripping (with flags -S) in /nix/store/7zs581l2vpk74wwfsi9qihwcbwfgan7w-nspr-4.18/lib
patching script interpreter paths in /nix/store/7zs581l2vpk74wwfsi9qihwcbwfgan7w-nspr-4.18
checking for references to /build in /nix/store/7zs581l2vpk74wwfsi9qihwcbwfgan7w-nspr-4.18...
shrinking RPATHs of ELF executables and libraries in /nix/store/qzhsigizbk5i8rxa89rax5wyqnq2cpfs-nspr-4.18-dev
stripping (with flags -S) in /nix/store/qzhsigizbk5i8rxa89rax5wyqnq2cpfs-nspr-4.18-dev/lib  /nix/store/qzhsigizbk5i8rxa89rax5wyqnq2cpfs-nspr-4.18-dev/bin
patching script interpreter paths in /nix/store/qzhsigizbk5i8rxa89rax5wyqnq2cpfs-nspr-4.18-dev
/nix/store/qzhsigizbk5i8rxa89rax5wyqnq2cpfs-nspr-4.18-dev/bin/nspr-config: interpreter directive changed from "/bin/sh" to "/nix/store/7b94zsymp6g5rzp2pgwhpkw0idjg52x5-bash-4.4-p12/bin/sh"
checking for references to /build in /nix/store/qzhsigizbk5i8rxa89rax5wyqnq2cpfs-nspr-4.18-dev...
/nix/store/7zs581l2vpk74wwfsi9qihwcbwfgan7w-nspr-4.18

@andir andir merged commit 721839a into NixOS:release-17.09 Mar 20, 2018
@andir andir deleted the 17.09/firefox branch March 20, 2018 05:05
@pbogdan
Copy link
Member

pbogdan commented Mar 20, 2018

It seems like this needs nss update as well - https://hydra.nixos.org/build/71543368/nixlog/1 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: rust 10.rebuild-darwin: 11-100 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@andir @vcunat @GrahamcOfBorg @pbogdan @taku0 @ryantm