Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

luakit: init at 2018.08.10 #37312

Merged
merged 1 commit into from Apr 9, 2018
Merged

luakit: init at 2018.08.10 #37312

merged 1 commit into from Apr 9, 2018

Conversation

lprndn
Copy link
Contributor

@lprndn lprndn commented Mar 18, 2018 •
edited

Motivation for this change

Since the package removal #23205 there has been two releases. Switching to a newer version of webkitgtk.
Most alternatives in nixpkgs seem to still use webkitgtk2.4.

Things done

It's based on the previous definition of luakit. It builds and I used it without troubles during the past 24h.
Still, some parts of nixpkgs are still a mystery to me so a review would be very welcome. (wrappers and gstreamer for example).

@matthiasbeyer , as previous maintainer, maybe you are still interested.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • [] Fits CONTRIBUTING.md.

@matthiasbeyer
Copy link
Contributor

@GrahamcOfBorg build luakit

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin

The following builds were skipped because they don't evaluate on x86_64-darwin: luakit

No log is available.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: luakit

Partial log (click to expand)

checking for references to /build in /nix/store/w21npw1l649xlcac1kzna13c10z3kgyn-gst-plugins-good-1.12.3-dev...
building of '/nix/store/6mm6pr840z429p4l9mk62gh7mr6khj3k-rustc-1.24.0.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/wsycxxpy4fin6rmfmx67n1b5pdzjww20-cargo-0.24.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/46dabb3yhvbzls28k7qhwvlxsm59sw04-librsvg-2.42.2.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/mw87libhfziaf7cnc775qx6j3kgzra5g-gst-plugins-bad-1.12.3.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/ghb2lx3ij1jyj0aa4v097pcxpyrrkk7p-hook.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/s0cxfqpsk6nxxkbbfbpwmid2g9862phk-geoclue-2.4.7.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/g4vz8vxfsmksnk2xlcdjxdqm71wiccbk-webkitgtk-2.18.6.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/xgz9cminyjq8npnwvq281zqh90dc7p3y-luakit-2017.08.10.drv': 3 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/xgz9cminyjq8npnwvq281zqh90dc7p3y-luakit-2017.08.10.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: luakit

Partial log (click to expand)

[  8%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/dfg/DFGInPlaceAbstractState.cpp.o
[  8%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/dfg/DFGInferredTypeCheck.cpp.o
[  8%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/dfg/DFGInsertionSet.cpp.o
[  8%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/dfg/DFGIntegerCheckCombiningPhase.cpp.o
[  8%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/dfg/DFGIntegerRangeOptimizationPhase.cpp.o
[  8%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/dfg/DFGInvalidationPointInjectionPhase.cpp.o
[  8%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/dfg/DFGJITCode.cpp.o
building of '/nix/store/jpv973yg03pg27dwk9ppf403732588m9-webkitgtk-2.18.6.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/6xa97dhx66vbl821scvdnrrcq27k9cg7-luakit-2017.08.10.drv': 1 dependencies couldn't be built
error: build of '/nix/store/6xa97dhx66vbl821scvdnrrcq27k9cg7-luakit-2017.08.10.drv' failed

@lprndn
Copy link
Contributor Author

lprndn commented Mar 28, 2018

Build faillures seem related to webkitgtk. What should we do?

@matthewbauer matthewbauer merged commit 39132f6 into NixOS:master Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lprndn @matthiasbeyer @GrahamcOfBorg @matthewbauer