Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 38c4c3acd7d8
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 2fa2197a96fe
Choose a head ref
  • 4 commits
  • 7 files changed
  • 2 contributors

Commits on Mar 14, 2018

  1. Configuration menu
    Copy the full SHA
    4c52e34 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2018

  1. lib, stdenv: Check meta.platforms against host platform and be open…

    … world
    
    First, we need check against the host platform, not the build platform.
    That's simple enough.
    
    Second, we move away from exahustive finite case analysis (i.e.
    exhaustively listing all platforms the package builds on). That only
    work in a closed-world setting, where we know all platforms we might
    build one. But with cross compilation, we may be building for arbitrary
    platforms, So we need fancier filters. This is the closed world to open
    world change.
    
    The solution is instead of having a list of systems (strings in the form
    "foo-bar"), we have a list of of systems or "patterns", i.e. attributes
    that partially match the output of the parsers in `lib.systems.parse`.
    The "check meta" logic treats the systems strings as an exact whitelist
    just as before, but treats the patterns as a fuzzy whitelist,
    intersecting the actual `hostPlatform` with the pattern and then
    checking for equality. (This is done using `matchAttrs`).
    
    The default convenience lists for `meta.platforms` are now changed to be
    lists of patterns (usually a single pattern) in
    `lib/systems/for-meta.nix` for maximum flexibility under this new
    system.
    
    Fixes #30902
    Ericson2314 committed Mar 15, 2018
    Configuration menu
    Copy the full SHA
    c26252a View commit details
    Browse the repository at this point in the history
  2. release-lib: Adapt to work with new meta.platforms

    `packagePlatforms` now filters `supportedSystems` with the new-style
    `meta.platforms`, rather than just plopping it in as is.
    Ericson2314 committed Mar 15, 2018
    Configuration menu
    Copy the full SHA
    eae19f3 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2018

  1. Configuration menu
    Copy the full SHA
    2fa2197 View commit details
    Browse the repository at this point in the history