Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unifi: 5.6.30 -> 5.6.36 #37351

Merged
merged 1 commit into from Mar 19, 2018
Merged

unifi: 5.6.30 -> 5.6.36 #37351

merged 1 commit into from Mar 19, 2018

Conversation

badmutex
Copy link
Contributor

Release Notes

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@peterhoeg peterhoeg merged commit 4fe3edd into NixOS:master Mar 19, 2018
@peterhoeg
Copy link
Member

Can I get you to open a PR for 18.03 where you git cherry-pick -x the commit on master?

@badmutex
Copy link
Contributor Author

Sure! Just to clarify, I should cherry pick onto the 18.03 branch and submit PR targeting that?

@peterhoeg
Copy link
Member

  1. Create new branch off release-18.03
  2. Cherry-pick with -x
  3. Push back to github and open PR against release-18.03
  4. Ping me in the PR please

@badmutex badmutex deleted the unifi branch March 20, 2018 02:01
@badmutex badmutex mentioned this pull request Mar 20, 2018
Merged
8 tasks
@xeji xeji mentioned this pull request Apr 27, 2018
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@badmutex @peterhoeg @GrahamcOfBorg