qutebrowser: patch scripts #37316
Merged
qutebrowser: patch scripts #37316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failure on x86_64-darwin (full log) Attempted: qutebrowser Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Attempted: qutebrowser Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: qutebrowser Partial log (click to expand)
|
|
@rnhmjoj I tried to run but I got: Did I run it correctly? |
|
No, you did nothing wrong. I patched the scripts and they now run but this one is trying to write into the nix store. I'm not sure how to deal with this. |
|
The path it tries to write to is |
rnhmjoj
force-pushed
the
qutefix
branch
2 times, most recently
from
1166714
to
fe13916
Compare
|
Failure on x86_64-darwin (full log) Attempted: qutebrowser Partial log (click to expand)
|
|
Failure on x86_64-linux (full log) Attempted: qutebrowser Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Attempted: qutebrowser Partial log (click to expand)
|
|
@rnhmjoj When I run I get |
|
Sorry, I didn't have time to test it yesterday. It should work now. |
|
Success on x86_64-linux (full log) Attempted: qutebrowser Partial log (click to expand)
|
|
Failure on x86_64-darwin (full log) Attempted: qutebrowser Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Attempted: qutebrowser Partial log (click to expand)
|
|
Thanks. |
|
No, I don't know how it's supposed to work. Maybe the path is hardcoded in qtwebengine... |
|
It indeed used to be hardcoded in QtWebEngine - however, I added a patch to Qt 5.10 to add a So, as soon as NixOS updates to Qt >= 5.10, you should be able to set that to a custom path - until then, I don't think there's anything you can do. |
|
@The-Compiler We actually have Qt 5.10! I tried it and seems to work, thank you. |
|
Huh, so is https://nixos.org/nixos/packages.html#qtwebengine outdated somehow?
I agree, it's currently tracked as part of qutebrowser/qutebrowser#2939 - at that point, it should also be possible to install dictionaries from inside qutebrowser instead of having a separate script. But like I said above, I haven't had time to look at that yet 😉 |
|
@The-Compiler |
|
Ok, it should be all set. |
|
Failure on x86_64-darwin (full log) Attempted: qutebrowser Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Attempted: qutebrowser Partial log (click to expand)
|
|
To make this work on 1.3.0, use this commit. |
|
@magnetophon Thanks. Finally, a spell checker in qutebrowser on nixos. |
|
This commit has changed |
|
Upstream here - with that commit, at least setting |
|
Ok, I removed the last commit. |
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: qutebrowser Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: qutebrowser Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Attempted: qutebrowser Partial log (click to expand)
|
|
Check the build again since there was a version bump |
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: qutebrowser Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: qutebrowser Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: qutebrowser Partial log (click to expand)
|
xeji
approved these changes
Sep 5, 2018
|
I am running qutebrowser with this patch. I was trying to use qute-pass but got this: I am not sure if it's an error or warning (not being able to cache tlds should not be an error), in the end I have to rework my pass store to make it work with qute-pass so I am unsure if I will keep using it. Just wanted to mention it. |
|
It looks like tldextract trying to write a cache in the nix store. Maybe it can be configured to to use adifferent path or just patched. |
|
If a script tries to write in the nix store by default I would consider this a bug, and it should be patched to use a sensible default location instead. |
|
That's not coming from one of qutebrowser's scripts, it's coming from tldextract - see e.g. From a quick look at its source, it seems to be possible to set |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fix #37307
Things done