Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terminus: init at 1.0.0-alpha.42 #37341

Merged
merged 1 commit into from Apr 5, 2018
Merged

terminus: init at 1.0.0-alpha.42 #37341

merged 1 commit into from Apr 5, 2018

Conversation

jlesquembre
Copy link
Member

@jlesquembre jlesquembre commented Mar 18, 2018 •
edited

Motivation for this change

terminus: init at 1.0.0-alpha.42

Since it is an electron app I'm not building it from source (not sure how to do it). I only adapted the hyper package: https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/misc/hyper/default.nix

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@pbogdan
Copy link
Member

pbogdan commented Mar 19, 2018

@GrahamcOfBorg eval

@Mic92
Copy link
Member

Mic92 commented Mar 19, 2018

The plugin manager wants npm, should this package add npm to its path?

@jlesquembre
Copy link
Member Author

@Mic92 good catch.
Not sure about it, I can add it if you think it's a good idea

@Mic92
Copy link
Member

Mic92 commented Mar 24, 2018

I think it is. A simple makeWrapper should do it.

@jlesquembre
Copy link
Member Author

ok, done.
I also updated the package to 1.0.0-alpha.42

@jlesquembre jlesquembre changed the title terminus: init at 1.0.0-alpha.41 terminus: init at 1.0.0-alpha.42 Mar 24, 2018
@Mic92 Mic92 merged commit b0a2fcb into NixOS:master Apr 5, 2018
@jlesquembre jlesquembre deleted the terminus branch April 29, 2018 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jlesquembre @pbogdan @Mic92 @GrahamcOfBorg