Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

easystroke: init at 0.6.0-9-gf7c1614 #37353

Closed
wants to merge 2 commits into from
Closed

easystroke: init at 0.6.0-9-gf7c1614 #37353

wants to merge 2 commits into from

Conversation

psyky
Copy link

@psyky psyky commented Mar 19, 2018 •
edited

Motivation for this change

easystroke: init at 0.6.0-9-gf7c1614

Easystroke is a X11 gesture recognition application.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@psyky psyky changed the title Easystroke easystroke: init at 0.6.0-9-gf7c1614 Mar 19, 2018
andir
andir requested changes Mar 21, 2018
View reviewed changes
Copy link
Member

@andir andir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

I left some comments in the review.

pkgs/applications/misc/easystroke/default.nix
enableParallelBuild = true;

patches = [
(fetchpatch {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why those patches are required? Did you attempt to submit them to upstream if they are an essential part of the package?

pkgs/applications/misc/easystroke/default.nix
};

nativeBuildInputs = [ pkgconfig gcc7 wrapGAppsHook help2man ];
buildInputs = [ boost dbus_glib gnome3.gtkmm xorg.libXtst xorg.inputproto
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the indention & order here?

Sorting dependencies alphabetically and having a common indention level across all list elements is what most people seem to do. Unfortunately, there is no style guide (yet).

pkgs/applications/misc/easystroke/default.nix
let
version = "0.6.0-9-gf7c1614";
in stdenv.mkDerivation {
name = "easystroke-${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to our naming guide (https://nixos.org/nixpkgs/manual/#sec-package-naming) the package name should probably be (final form after evaluation): easystroke-unstable-2000-01-31 (with correct date)

pkgs/applications/misc/easystroke/default.nix
@@ -0,0 +1,55 @@
{ stdenv, fetchFromGitHub, fetchpatch, pkgconfig, boost, dbus_glib, gnome3,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you specify gcc7 there (& within nativeBuildInputs)? Usually sticking with just using whatever stdenv provides is what you want.

@andir
Copy link
Member

andir commented Mar 21, 2018

@GrahamcOfBorg build easystroke

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: easystroke

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: easystroke

Partial log (click to expand)

hicolorPreFixupPhase
post-installation fixup
Wrapping program /nix/store/2b1xacc9n6b4s11fmdx5bg51khv03xch-easystroke-0.6.0-9-gf7c1614/bin/easystroke
shrinking RPATHs of ELF executables and libraries in /nix/store/2b1xacc9n6b4s11fmdx5bg51khv03xch-easystroke-0.6.0-9-gf7c1614
shrinking /nix/store/2b1xacc9n6b4s11fmdx5bg51khv03xch-easystroke-0.6.0-9-gf7c1614/bin/.easystroke-wrapped
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/2b1xacc9n6b4s11fmdx5bg51khv03xch-easystroke-0.6.0-9-gf7c1614/bin
patching script interpreter paths in /nix/store/2b1xacc9n6b4s11fmdx5bg51khv03xch-easystroke-0.6.0-9-gf7c1614
checking for references to /tmp/nix-build-easystroke-0.6.0-9-gf7c1614.drv-0 in /nix/store/2b1xacc9n6b4s11fmdx5bg51khv03xch-easystroke-0.6.0-9-gf7c1614...
/nix/store/2b1xacc9n6b4s11fmdx5bg51khv03xch-easystroke-0.6.0-9-gf7c1614

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: easystroke

Partial log (click to expand)

   Compiling rustc_save_analysis v0.0.0 (file:///build/rustc-1.24.0-src/src/librustc_save_analysis)
   Compiling rustc_plugin v0.0.0 (file:///build/rustc-1.24.0-src/src/librustc_plugin)
building of '/nix/store/6mm6pr840z429p4l9mk62gh7mr6khj3k-rustc-1.24.0.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/wsycxxpy4fin6rmfmx67n1b5pdzjww20-cargo-0.24.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/byqkqqkjq1m38ikbxxrirk81d0wr4qns-librsvg-2.42.2.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/azb669rka042skzps2bpc7m7bs1r5afm-hook.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/9m843nlahfvzxpcqhxqy1qb5cz6jwa5a-icon-naming-utils-0.8.90.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/wsgyalfxylcxbs6nlf4kd7p9cvxc1f1b-adwaita-icon-theme-3.26.1.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/b8si13r2gnai8zmr64bilk094xfzgrjx-easystroke-0.6.0-9-gf7c1614.drv': 2 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/b8si13r2gnai8zmr64bilk094xfzgrjx-easystroke-0.6.0-9-gf7c1614.drv' failed

@ivan ivan mentioned this pull request Dec 17, 2018
Closed
10 tasks
ivan added a commit to ivan/nixpkgs that referenced this pull request Jan 13, 2019
@ivan
easystroke: init at unstable-2016-07-05
14bf75f 
This commit is based on work by Andreas Schaefer in
NixOS#37353
@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/26

@timokau
Copy link
Member

timokau commented Jun 27, 2019

Replaced by #52424.

@timokau timokau closed this Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andir andir andir requested changes

Assignees
No one assigned
Labels
2.status: merge conflict 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@psyky @andir @GrahamcOfBorg @nixos-discourse @timokau @samueldr @Janik-Haag