Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.notebook: fix darwin build #37354

Merged
merged 1 commit into from Mar 19, 2018
Merged

pythonPackages.notebook: fix darwin build #37354

merged 1 commit into from Mar 19, 2018

Conversation

knedlsepp
Copy link
Member

Motivation for this change

18.03 ZHF darwin edition: #36454 (Please backport to 18.03!)
Since send2trash's tests don't work properly on darwin (something related to build user privileges), yet still they actually seem to work fine in practice, we simply don't run these tests for the notebook.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@knedlsepp
pythonPackages.notebook: fix darwin build
8aaa17c 
The send2trash library, which is now included in the notebook doesn't
succeed during build, even though it works.
@knedlsepp knedlsepp requested a review from FRidh as a code owner March 19, 2018 00:19
@LnL7
Copy link
Member

LnL7 commented Mar 19, 2018

@GrahamcOfBorg build pythonPackages.notebook

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: pythonPackages.notebook

Partial log (click to expand)

  Warning)
/nix/store/gj0c7739zmjlbi9rg8s7fm8wwhn9kciy-python2.7-ipython_genutils-0.2.0/lib/python2.7/site-packages/ipython_genutils/tempdir.py:58: Warning: Implicitly cleaning up <ipython_genutils.tempdir.TemporaryDirectory object at 0x10fc5ca90>
  Warning)
/nix/store/gj0c7739zmjlbi9rg8s7fm8wwhn9kciy-python2.7-ipython_genutils-0.2.0/lib/python2.7/site-packages/ipython_genutils/tempdir.py:58: Warning: Implicitly cleaning up <ipython_genutils.tempdir.TemporaryDirectory object at 0x10fc5cdd0>
  Warning)
/nix/store/gj0c7739zmjlbi9rg8s7fm8wwhn9kciy-python2.7-ipython_genutils-0.2.0/lib/python2.7/site-packages/ipython_genutils/tempdir.py:58: Warning: Implicitly cleaning up <ipython_genutils.tempdir.TemporaryDirectory object at 0x10fc5cf10>
  Warning)
/nix/store/gj0c7739zmjlbi9rg8s7fm8wwhn9kciy-python2.7-ipython_genutils-0.2.0/lib/python2.7/site-packages/ipython_genutils/tempdir.py:58: Warning: Implicitly cleaning up <ipython_genutils.tempdir.TemporaryDirectory object at 0x10fc5c310>
  Warning)
/nix/store/9q78b4dji653hv8cqn6ra5ryhsa13s1j-python2.7-notebook-5.4.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pythonPackages.notebook

Partial log (click to expand)

  Warning)
/nix/store/v8aydgcwjrfqiknjd0a00kcj9rsy72i1-python2.7-ipython_genutils-0.2.0/lib/python2.7/site-packages/ipython_genutils/tempdir.py:58: Warning: Implicitly cleaning up <ipython_genutils.tempdir.TemporaryDirectory object at 0x7fffe43eacd0>
  Warning)
/nix/store/v8aydgcwjrfqiknjd0a00kcj9rsy72i1-python2.7-ipython_genutils-0.2.0/lib/python2.7/site-packages/ipython_genutils/tempdir.py:58: Warning: Implicitly cleaning up <ipython_genutils.tempdir.TemporaryDirectory object at 0x7fffe43eaf50>
  Warning)
/nix/store/v8aydgcwjrfqiknjd0a00kcj9rsy72i1-python2.7-ipython_genutils-0.2.0/lib/python2.7/site-packages/ipython_genutils/tempdir.py:58: Warning: Implicitly cleaning up <ipython_genutils.tempdir.TemporaryDirectory object at 0x7fffe4574850>
  Warning)
/nix/store/v8aydgcwjrfqiknjd0a00kcj9rsy72i1-python2.7-ipython_genutils-0.2.0/lib/python2.7/site-packages/ipython_genutils/tempdir.py:58: Warning: Implicitly cleaning up <ipython_genutils.tempdir.TemporaryDirectory object at 0x7fffe4574f90>
  Warning)
/nix/store/m7962yiamlgm1gvj0lfy293n2qfw9p9b-python2.7-notebook-5.4.0

@LnL7 LnL7 merged commit 3539ca2 into NixOS:master Mar 19, 2018
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pythonPackages.notebook

Partial log (click to expand)

  Warning)
/nix/store/f8lwnpv7mi69zxhixvl4sp9zi32jyyfz-python2.7-ipython_genutils-0.2.0/lib/python2.7/site-packages/ipython_genutils/tempdir.py:58: Warning: Implicitly cleaning up <ipython_genutils.tempdir.TemporaryDirectory object at 0xffffb4276d10>
  Warning)
/nix/store/f8lwnpv7mi69zxhixvl4sp9zi32jyyfz-python2.7-ipython_genutils-0.2.0/lib/python2.7/site-packages/ipython_genutils/tempdir.py:58: Warning: Implicitly cleaning up <ipython_genutils.tempdir.TemporaryDirectory object at 0xffffb4276810>
  Warning)
/nix/store/f8lwnpv7mi69zxhixvl4sp9zi32jyyfz-python2.7-ipython_genutils-0.2.0/lib/python2.7/site-packages/ipython_genutils/tempdir.py:58: Warning: Implicitly cleaning up <ipython_genutils.tempdir.TemporaryDirectory object at 0xffffb4281c50>
  Warning)
/nix/store/f8lwnpv7mi69zxhixvl4sp9zi32jyyfz-python2.7-ipython_genutils-0.2.0/lib/python2.7/site-packages/ipython_genutils/tempdir.py:58: Warning: Implicitly cleaning up <ipython_genutils.tempdir.TemporaryDirectory object at 0xffffb4281bd0>
  Warning)
/nix/store/rjbnvkq4qyhb7l2xz18363admg6gdr2n-python2.7-notebook-5.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@knedlsepp @LnL7 @GrahamcOfBorg