Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile: 1.11.14 -> 2.0 #1987

Merged
merged 2 commits into from Mar 19, 2018
Merged

Dockerfile: 1.11.14 -> 2.0 #1987

merged 2 commits into from Mar 19, 2018

Conversation

bchallenor
Copy link
Contributor

Updates nix to 2.0.

I'd like to verify the checksum though. Should I raise that as an issue / create another PR?

@bchallenor
Copy link
Contributor Author

I added a commit to verify the checksum with sha256sum. Let me know if you disagree with the approach.

@shlevy
Copy link
Member

shlevy commented Mar 19, 2018

LGTM, @peti @domenkozar can I get a second look? I don't have a setup to test this yet.

@shlevy shlevy merged commit a74288b into NixOS:master Mar 19, 2018
@bchallenor
Copy link
Contributor Author

Thanks. How does this get pushed to the Docker Hub - is it manual?

@shlevy
Copy link
Member

shlevy commented Mar 20, 2018

@edolstra ^ ?

@edolstra
Copy link
Member

No idea, sorry.

@domenkozar
Copy link
Member

I push it - happy to extend access list :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti peti approved these changes

@domenkozar domenkozar domenkozar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bchallenor @shlevy @edolstra @domenkozar @peti