pythonPackages.pytest-flake8: 0.9.1 -> 1.0.0 #37971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jluttine
force-pushed
the
upgrade-pytest-flake8
branch
from
4c76695
to
5f93c20
Compare
dotlambda
requested changes
Mar 30, 2018
| @@ -3,7 +3,7 @@ | |||
| buildPythonPackage rec { | |||
| name = "${pname}-${version}"; | |||
| @@ -3,7 +3,7 @@ | |||
| buildPythonPackage rec { | |||
| name = "${pname}-${version}"; | |||
| pname = "pytest-flake8"; | |||
| version = "0.9.1"; | |||
| version = "1.0.0"; | |||
|
|
|||
| # although pytest is a runtime dependency, do not add it as | |||
| # propagatedBuildInputs in order to allow packages depend on another version | |||
There was a problem hiding this comment.
I believe this comment should be removed and pytest moved to propagatedBuildInputs, because applications can use their own pytest version using packageOverrides. Shouldn't it, @FRidh?
There was a problem hiding this comment.
In case of pytest it is not just for applications, but also for libraries. Certain libraries may request a certain pytest version.
There was a problem hiding this comment.
So I'll keep it as it is or change it somehow?
There was a problem hiding this comment.
Ok, thanks! Then I think this should be ready to merge.
jluttine
force-pushed
the
upgrade-pytest-flake8
branch
from
5f93c20
to
aef1900
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Upgrade pytest-flake8.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)