Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qpdfview: port to qt5 #37986

Merged
merged 2 commits into from Apr 30, 2018
Merged

qpdfview: port to qt5 #37986

merged 2 commits into from Apr 30, 2018

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Mar 28, 2018

Motivation for this change

See #32883

Depends on: #37693

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: qpdfview

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: qpdfview

Partial log (click to expand)

make[1]: Entering directory '/tmp/nix-build-qpdfview-0.4.16.drv-0/qpdfview-0.4.16'
mkdir:
cannot create directory '/1rz4g4znpzjwh1xymhjpm42vipw92pr73vdgl6xs1hycac8kf2n9'
: Permission denied

make[1]: *** [Makefile.pdf-plugin:438: install_target] Error 1
make[1]: Leaving directory '/tmp/nix-build-qpdfview-0.4.16.drv-0/qpdfview-0.4.16'
make: *** [Makefile:62: sub-pdf-plugin-pro-install_subtargets-ordered] Error 2
builder for ‘/nix/store/sn6srv73pncl8wspp7qx20px7smkn14f-qpdfview-0.4.16.drv’ failed with exit code 2
error: build of ‘/nix/store/sn6srv73pncl8wspp7qx20px7smkn14f-qpdfview-0.4.16.drv’ failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: qpdfview

Partial log (click to expand)

   Compiling rustc_resolve v0.0.0 (file:///build/rustc-1.24.0-src/src/librustc_resolve)
   Compiling rustc_mir v0.0.0 (file:///build/rustc-1.24.0-src/src/librustc_mir)
   Compiling rustc_passes v0.0.0 (file:///build/rustc-1.24.0-src/src/librustc_passes)
   Compiling rustc_lint v0.0.0 (file:///build/rustc-1.24.0-src/src/librustc_lint)
building of '/nix/store/hbh7hc1fmhgrf854fw2adjxzfq4dlvjx-rustc-1.24.0.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/141qh0sk0wj978wq7p03k61lzgaay8rd-cargo-0.24.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/pgqs1hs22yjrj6i2wqzcmk9sbz35rx1d-librsvg-2.42.2.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/4ayb772nf27a6468d7y836vpp9akmslg-djvulibre-3.5.27.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/yiig1547gcvlrv1h9z0r1zy0s4wnrmrl-qpdfview-0.4.16.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/yiig1547gcvlrv1h9z0r1zy0s4wnrmrl-qpdfview-0.4.16.drv' failed

Copy link
Member

@matthewbauer matthewbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See @GrahamcOfBorg log failures

@dtzWill
Copy link
Member

dtzWill commented Apr 23, 2018

@GrahamcOfBorg build qpdfview

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: qpdfview

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: qpdfview

Partial log (click to expand)

shrinking /nix/store/6dhk4ch4j88kffq8n3bmpklqnp7j96wx-qpdfview-0.4.16/lib/qpdfview/libqpdfview_pdf.so
gzipping man pages under /nix/store/6dhk4ch4j88kffq8n3bmpklqnp7j96wx-qpdfview-0.4.16/share/man/
strip is /nix/store/j7d4mr0ikv974ig7yzhknpsq288js4bs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/6dhk4ch4j88kffq8n3bmpklqnp7j96wx-qpdfview-0.4.16/lib  /nix/store/6dhk4ch4j88kffq8n3bmpklqnp7j96wx-qpdfview-0.4.16/bin
patching script interpreter paths in /nix/store/6dhk4ch4j88kffq8n3bmpklqnp7j96wx-qpdfview-0.4.16
checking for references to /build in /nix/store/6dhk4ch4j88kffq8n3bmpklqnp7j96wx-qpdfview-0.4.16...
postPatchMkspecs
postPatchMkspecs
postPatchMkspecs
/nix/store/6dhk4ch4j88kffq8n3bmpklqnp7j96wx-qpdfview-0.4.16

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: qpdfview

Partial log (click to expand)

shrinking /nix/store/p7fm795r7lrl84i4i2kkwkgiwl01lncz-qpdfview-0.4.16/bin/qpdfview
gzipping man pages under /nix/store/p7fm795r7lrl84i4i2kkwkgiwl01lncz-qpdfview-0.4.16/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/p7fm795r7lrl84i4i2kkwkgiwl01lncz-qpdfview-0.4.16/lib  /nix/store/p7fm795r7lrl84i4i2kkwkgiwl01lncz-qpdfview-0.4.16/bin
patching script interpreter paths in /nix/store/p7fm795r7lrl84i4i2kkwkgiwl01lncz-qpdfview-0.4.16
checking for references to /build in /nix/store/p7fm795r7lrl84i4i2kkwkgiwl01lncz-qpdfview-0.4.16...
postPatchMkspecs
postPatchMkspecs
postPatchMkspecs
/nix/store/p7fm795r7lrl84i4i2kkwkgiwl01lncz-qpdfview-0.4.16

@matthewbauer
Copy link
Member

Okay nevermind then!

@jtojnar
Copy link
Contributor Author

jtojnar commented Apr 23, 2018

This uses placeholder syntax from Nix 2, so it should not be merged until #37693 is.

@jtojnar
Copy link
Contributor Author

jtojnar commented Apr 30, 2018

I will just revert the second commit in #37693

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: qpdfview

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: qpdfview

Partial log (click to expand)

shrinking /nix/store/h4bdrmyi56hkhqfxywvp3s24khazbrvw-qpdfview-0.4.16/bin/qpdfview
gzipping man pages under /nix/store/h4bdrmyi56hkhqfxywvp3s24khazbrvw-qpdfview-0.4.16/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/h4bdrmyi56hkhqfxywvp3s24khazbrvw-qpdfview-0.4.16/lib  /nix/store/h4bdrmyi56hkhqfxywvp3s24khazbrvw-qpdfview-0.4.16/bin
patching script interpreter paths in /nix/store/h4bdrmyi56hkhqfxywvp3s24khazbrvw-qpdfview-0.4.16
checking for references to /build in /nix/store/h4bdrmyi56hkhqfxywvp3s24khazbrvw-qpdfview-0.4.16...
postPatchMkspecs
postPatchMkspecs
postPatchMkspecs
/nix/store/h4bdrmyi56hkhqfxywvp3s24khazbrvw-qpdfview-0.4.16

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: qpdfview

Partial log (click to expand)

shrinking /nix/store/r02kk9n7gv4qwjzkbz82xqdiylhwapxb-qpdfview-0.4.16/lib/qpdfview/libqpdfview_pdf.so
gzipping man pages under /nix/store/r02kk9n7gv4qwjzkbz82xqdiylhwapxb-qpdfview-0.4.16/share/man/
strip is /nix/store/gp7fylxwn18b7pl2c18ks89hsiaxyfvf-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/r02kk9n7gv4qwjzkbz82xqdiylhwapxb-qpdfview-0.4.16/lib  /nix/store/r02kk9n7gv4qwjzkbz82xqdiylhwapxb-qpdfview-0.4.16/bin
patching script interpreter paths in /nix/store/r02kk9n7gv4qwjzkbz82xqdiylhwapxb-qpdfview-0.4.16
checking for references to /build in /nix/store/r02kk9n7gv4qwjzkbz82xqdiylhwapxb-qpdfview-0.4.16...
postPatchMkspecs
postPatchMkspecs
postPatchMkspecs
/nix/store/r02kk9n7gv4qwjzkbz82xqdiylhwapxb-qpdfview-0.4.16

@jtojnar jtojnar merged commit 205d9a7 into NixOS:master Apr 30, 2018
@jtojnar jtojnar deleted the qpdfview-qt5 branch April 30, 2018 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants