Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

systemd: disable EFI support on AArch64 #37996

Merged
merged 1 commit into from Mar 28, 2018
Merged

systemd: disable EFI support on AArch64 #37996

merged 1 commit into from Mar 28, 2018

Conversation

abbradar
Copy link
Member

@abbradar abbradar commented Mar 28, 2018 •
edited

It seemingly isn't used by NixOS and currently breaks AArch64 build.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Waiting for @GrahamcOfBorg to build it.

@abbradar
systemd: disable EFI support on AArch64
0402877 
It seemingly isn't used by NixOS and currently breaks AArch64 build.
@abbradar abbradar requested a review from dezgeg March 28, 2018 12:44
@abbradar abbradar changed the title systemd: disable EFI support on AArch64 [WIP] systemd: disable EFI support on AArch64 Mar 28, 2018
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: systemd

Partial log (click to expand)

Cannot nix-instantiate `systemd' because:
�[31;1merror:�[0m while evaluating 'callPackageWith' at �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix�[0m:113:35, called from �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/top-level/all-packages.nix�[0m:13855:13:
while evaluating 'makeOverridable' at �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix�[0m:72:24, called from �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix�[0m:117:8:
while evaluating anonymous function at �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/systemd/default.nix�[0m:1:1, called from �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix�[0m:74:12:
assertion failed at �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/systemd/default.nix�[0m:15:1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: systemd

Partial log (click to expand)

/nix/store/nr9f5y6ij6sbxpzmax92qy6xfxqz7z17-systemd-238

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: systemd

Partial log (click to expand)

gzipping man pages under /nix/store/v3kin5ggg081brqnlw5gwnjidmgpi53h-systemd-238-man/share/man/
strip is /nix/store/j7d4mr0ikv974ig7yzhknpsq288js4bs-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/v3kin5ggg081brqnlw5gwnjidmgpi53h-systemd-238-man
checking for references to /build in /nix/store/v3kin5ggg081brqnlw5gwnjidmgpi53h-systemd-238-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/4qn5zxpvp2gjq565crcrw5q4cc2fsf68-systemd-238-dev
strip is /nix/store/j7d4mr0ikv974ig7yzhknpsq288js4bs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4qn5zxpvp2gjq565crcrw5q4cc2fsf68-systemd-238-dev/lib
patching script interpreter paths in /nix/store/4qn5zxpvp2gjq565crcrw5q4cc2fsf68-systemd-238-dev
checking for references to /build in /nix/store/4qn5zxpvp2gjq565crcrw5q4cc2fsf68-systemd-238-dev...
/nix/store/kbg9l4d2di3pbdsygcrxk2y5j6ggn1bq-systemd-238

@abbradar abbradar changed the title [WIP] systemd: disable EFI support on AArch64 systemd: disable EFI support on AArch64 Mar 28, 2018
@shlevy shlevy merged commit 0402877 into NixOS:staging Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shlevy shlevy shlevy approved these changes

@dezgeg dezgeg Awaiting requested review from dezgeg

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@abbradar @GrahamcOfBorg @shlevy