Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/dhcp: fix permissions of statedir #38425

Merged
merged 1 commit into from Apr 4, 2018

Conversation

qknight
Copy link
Member

@qknight qknight commented Apr 4, 2018

fix for #38424

(not tested)

@qknight qknight mentioned this pull request Apr 4, 2018
@Mic92 Mic92 changed the title fix for: https://github.com/NixOS/nixpkgs/issues/38424 nixos/dhcp: fix permissions of statedir Apr 4, 2018
@Mic92
Copy link
Member

Mic92 commented Apr 4, 2018

Please also adjust commit message accordingly or use the squash button to change the message.

@qknight
Copy link
Member Author

qknight commented Apr 4, 2018

@Mic92 what would be an 'correct' or 'good' commit message?

@Mic92
Copy link
Member

Mic92 commented Apr 4, 2018

I proposed one in the title.

@qknight qknight merged commit 7be79f2 into NixOS:master Apr 4, 2018
@qknight
Copy link
Member Author

qknight commented Apr 5, 2018

@Mic92 i'd like to have this in 18.03 also, can you tell me the documentation and processes to do that?

@abbradar
Copy link
Member

abbradar commented Apr 5, 2018

@qknight Before backporting could you address 7be79f2#commitcomment-28415075? I'm not sure I see an actual problem so wanted a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants