Fix String#tr 1 byte from optimization bug
#5913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref: crystal-lang#5912 (comment) `"aabbcc".tr("a", "xyz")` yields `"xyzxyzbbcc"` currently. Of course it is unintentional behavior, in Ruby it yields `"xxbbcc"` and on shell `echo aabbcc | tr a xyz` shows `xxbbcc`.
makenowjust
force-pushed
the
fix/string/tr-bug
branch
from
a083743
to
a6f5ed6
Compare
jhass
approved these changes
Apr 4, 2018
straight-shoota
approved these changes
Apr 4, 2018
|
Thank you! |
|
Please remember to milestone and label! |
|
I can't from my phone :( |
|
@ysbaddaden You should be able use the desktop view (link is at the bottom of the mobile page). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #5912 (comment)
"aabbcc".tr("a", "xyz")yields"xyzxyzbbcc"currently.Of course it is unintentional behavior, also bug. In Ruby it yields
"xxbbcc"and on shellecho aabbcc | tr a xyzshowsxxbbccin fact.