Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

beluga: init at 20180403 #38416

Merged
merged 1 commit into from Apr 5, 2018
Merged

beluga: init at 20180403 #38416

merged 1 commit into from Apr 5, 2018

Conversation

bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Apr 4, 2018

Motivation for this change

adding new package ...

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [NA] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [NA] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Mic92
Mic92 reviewed Apr 4, 2018
View reviewed changes
pkgs/applications/science/logic/beluga/default.nix Outdated

installPhase = ''
mkdir -p $out/bin
rsync -av bin $out/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why does cp -r not work here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mic92: OK, I've changed it ...

@Mic92 Mic92 merged commit d307ab5 into NixOS:master Apr 5, 2018
@bcdarwin bcdarwin deleted the beluga branch April 6, 2018 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bcdarwin @Mic92 @GrahamcOfBorg