Fix String#tr 1 byte from optimization bug

Ref: #5912 (comment) `"aabbcc".tr("a", "xyz")` yields `"xyzxyzbbcc"` currently. Of course it is unintentional behavior, in Ruby it yields `"xxbbcc"` and on shell `echo aabbcc | tr a xyz` shows `xxbbcc`.
crystal-lang · Apr 4, 2018 · 9662abe · 9662abe
1 parent ec423eb
commit 9662abe
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/spec/std/string_spec.cr b/spec/std/string_spec.cr
@@ -1718,6 +1718,8 @@ describe "String" do
       "hello".tr("helo", "1212").should eq("12112")
       "this".tr("this", "ⓧ").should eq("ⓧⓧⓧⓧ")
       "über".tr("ü", "u").should eq("uber")
+      "aabbcc".tr("a", "xyz").should eq("xxbbcc")
+      "aabbcc".tr("a", "いろは").should eq("いいbbcc")
     end
 
     context "given no replacement characters" do

diff --git a/src/string.cr b/src/string.cr
@@ -1591,7 +1591,7 @@ class String
     return delete(from) if to.empty?
 
     if from.bytesize == 1
-      return gsub(from.unsafe_byte_at(0).unsafe_chr, to)
+      return gsub(from.unsafe_byte_at(0).unsafe_chr, to[0])
     end
 
     multi = nil