Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable libtorrent and xmlrpc-c on darwin #38417

Merged
merged 2 commits into from Apr 4, 2018
Merged

Enable libtorrent and xmlrpc-c on darwin #38417

merged 2 commits into from Apr 4, 2018

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Apr 4, 2018

Motivation for this change

libtorrent and xmlrpc-c can be build on darwin, this change moves out rtorrent from broken packages in darwin

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Apr 4, 2018

@GrahamcOfBorg build rtorrent

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: rtorrent

Partial log (click to expand)

these paths will be fetched (1.27 MiB download, 6.49 MiB unpacked):
  /nix/store/86jd4ffhrld1wbmzy7ndgyg4gxmizzlj-xmlrpc-c-1.39.12
  /nix/store/dfs7ak98qg0hjryz7zqg0gpsgwzy7863-libtorrent-20161212
  /nix/store/ln2rcz8xzv1v06cl0pyg17z7pjnpnnvq-cppunit-1.14.0
  /nix/store/s68a4vq292cmhai8ddgavg11s0kddfpy-rtorrent-20161023
copying path '/nix/store/ln2rcz8xzv1v06cl0pyg17z7pjnpnnvq-cppunit-1.14.0' from 'https://cache.nixos.org'...
copying path '/nix/store/86jd4ffhrld1wbmzy7ndgyg4gxmizzlj-xmlrpc-c-1.39.12' from 'https://cache.nixos.org'...
copying path '/nix/store/dfs7ak98qg0hjryz7zqg0gpsgwzy7863-libtorrent-20161212' from 'https://cache.nixos.org'...
copying path '/nix/store/s68a4vq292cmhai8ddgavg11s0kddfpy-rtorrent-20161023' from 'https://cache.nixos.org'...
/nix/store/s68a4vq292cmhai8ddgavg11s0kddfpy-rtorrent-20161023

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: rtorrent

Partial log (click to expand)

-
-


3
4
9
k

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: rtorrent

Partial log (click to expand)

make[2]: Nothing to be done for 'install-exec-am'.
make[2]: Nothing to be done for 'install-data-am'.
make[2]: Leaving directory '/private/tmp/nix-build-rtorrent-20161023.drv-0/source'
make[1]: Leaving directory '/private/tmp/nix-build-rtorrent-20161023.drv-0/source'
post-installation fixup
gzipping man pages under /nix/store/smcppd20g8bnxqhvl8jdvh47vz14ahmf-rtorrent-20161023/share/man/
strip is /nix/store/0fzpxnsanc02i4jsb1yhchjp4p62b2n3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/smcppd20g8bnxqhvl8jdvh47vz14ahmf-rtorrent-20161023/bin
patching script interpreter paths in /nix/store/smcppd20g8bnxqhvl8jdvh47vz14ahmf-rtorrent-20161023
/nix/store/smcppd20g8bnxqhvl8jdvh47vz14ahmf-rtorrent-20161023

@Mic92 Mic92 merged commit a88ad6c into NixOS:master Apr 4, 2018
@Mic92
Copy link
Member

Mic92 commented Apr 4, 2018 •
edited

also backported:

git backport eb6a85e 88bb014
[detached HEAD 1a7464e] xmlrpc-c: enable darwin build
Author: Mario Rodas marsam@users.noreply.github.com
Date: Tue Apr 3 20:30:51 2018 -0500
1 file changed, 1 insertion(+), 1 deletion(-)
[detached HEAD e8982eb] libtorrent: enable darwin build
Author: Mario Rodas marsam@users.noreply.github.com
Date: Tue Apr 3 20:31:13 2018 -0500
1 file changed, 1 insertion(+), 1 deletion(-)

@marsam marsam deleted the feature/enable-libtorrent-xmlrpc-darwin branch April 4, 2018 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsam @Mic92 @GrahamcOfBorg