Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rocksdb_lite: Fix #38415

Merged
merged 2 commits into from Apr 4, 2018
Merged

rocksdb_lite: Fix #38415

merged 2 commits into from Apr 4, 2018

Conversation

infinisil
Copy link
Member

Motivation for this change

Didn't build before.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: rocksdb_lite

Partial log (click to expand)

strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/h0bbb3prljsrsk58miq50xrn0b2y178m-rocksdb-5.10.3/lib
patching script interpreter paths in /nix/store/h0bbb3prljsrsk58miq50xrn0b2y178m-rocksdb-5.10.3
checking for references to /tmp/nix-build-rocksdb-5.10.3.drv-0 in /nix/store/h0bbb3prljsrsk58miq50xrn0b2y178m-rocksdb-5.10.3...
shrinking RPATHs of ELF executables and libraries in /nix/store/720ahgsfxjxqsmr9nd7v9h9fhqg5m4mj-rocksdb-5.10.3-static
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/720ahgsfxjxqsmr9nd7v9h9fhqg5m4mj-rocksdb-5.10.3-static/lib
patching script interpreter paths in /nix/store/720ahgsfxjxqsmr9nd7v9h9fhqg5m4mj-rocksdb-5.10.3-static
checking for references to /tmp/nix-build-rocksdb-5.10.3.drv-0 in /nix/store/720ahgsfxjxqsmr9nd7v9h9fhqg5m4mj-rocksdb-5.10.3-static...
/nix/store/lkgb53pxif3x3sc0wmznfzc78h40m2xz-rocksdb-5.10.3-dev

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: rocksdb_lite

Partial log (click to expand)

./util/coding.h: In function 'uint64_t rocksdb::DecodeFixed64(const char*)':
./util/coding.h:114:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
make: *** [Makefile:1835: table/block_based_table_builder.o] Error 1
make: *** [Makefile:1835: db/db_impl_files.o] Error 1
make: *** [Makefile:1835: db/db_impl_readonly.o] Error 1
make: *** [Makefile:1835: db/db_impl_compaction_flush.o] Error 1
builder for '/nix/store/x7w593dyg5cwq0gdfxcfq11bzjhsac8p-rocksdb-5.10.3.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/x7w593dyg5cwq0gdfxcfq11bzjhsac8p-rocksdb-5.10.3.drv' failed

@infinisil infinisil mentioned this pull request Apr 4, 2018
Closed
infinisil
infinisil commented Apr 4, 2018
View reviewed changes
pkgs/development/libraries/rocksdb/default.nix
@@ -68,7 +68,7 @@ stdenv.mkDerivation rec {
echo "BUILD CONFIGURATION FOR SANITY CHECKING"
cat make_config.mk
mkdir -pv $static/lib/
mv -vi $out/lib/librocksdb.a $static/lib/
mv -vi $out/lib/${LIBNAME}.a $static/lib/
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem was that with enableLite, the library was called librocksdb_lite.a and not librocksdb.a, so the mv failed.

@infinisil
Copy link
Member Author

This was introduced with #36809

@Mic92
Copy link
Member

Mic92 commented Apr 4, 2018

@GrahamcOfBorg build rocksdb

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: rocksdb

Partial log (click to expand)

                 from ./db/builder.h:13,
                 from db/repair.cc:68:
./util/coding.h: In function 'uint64_t rocksdb::DecodeFixed64(const char*)':
./util/coding.h:114:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
make: *** [Makefile:1835: db/repair.o] Error 1
make: *** [Makefile:1835: db/internal_stats.o] Error 1
builder for '/nix/store/b43n768844vp2v1ib60wsyxf5lvfagjp-rocksdb-5.10.3.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/b43n768844vp2v1ib60wsyxf5lvfagjp-rocksdb-5.10.3.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: rocksdb

Partial log (click to expand)

strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/bqrq3r48ihg1n7xd1vs14wcx46r72jab-rocksdb-5.10.3/lib
patching script interpreter paths in /nix/store/bqrq3r48ihg1n7xd1vs14wcx46r72jab-rocksdb-5.10.3
checking for references to /tmp/nix-build-rocksdb-5.10.3.drv-0 in /nix/store/bqrq3r48ihg1n7xd1vs14wcx46r72jab-rocksdb-5.10.3...
shrinking RPATHs of ELF executables and libraries in /nix/store/f0ijqhq7fywhlv884v6dihdkx4jb6wpx-rocksdb-5.10.3-static
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/f0ijqhq7fywhlv884v6dihdkx4jb6wpx-rocksdb-5.10.3-static/lib
patching script interpreter paths in /nix/store/f0ijqhq7fywhlv884v6dihdkx4jb6wpx-rocksdb-5.10.3-static
checking for references to /tmp/nix-build-rocksdb-5.10.3.drv-0 in /nix/store/f0ijqhq7fywhlv884v6dihdkx4jb6wpx-rocksdb-5.10.3-static...
/nix/store/w3xbrcbrvb0127l8y983q56hyayx02h2-rocksdb-5.10.3-dev

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: rocksdb

Partial log (click to expand)

strip is /nix/store/0fzpxnsanc02i4jsb1yhchjp4p62b2n3-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/cmn97zbbzm2px7yga27k44x72gb68fjs-rocksdb-5.10.3-dev
strip is /nix/store/0fzpxnsanc02i4jsb1yhchjp4p62b2n3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/303f21fkgz11ra7xgyrgishm1aq5fn2d-rocksdb-5.10.3/lib
patching script interpreter paths in /nix/store/303f21fkgz11ra7xgyrgishm1aq5fn2d-rocksdb-5.10.3
/nix/store/303f21fkgz11ra7xgyrgishm1aq5fn2d-rocksdb-5.10.3/lib/librocksdb.5.10.3.dylib: fixing dylib
strip is /nix/store/0fzpxnsanc02i4jsb1yhchjp4p62b2n3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/xai53adxx2p68wfxs8gnpjzpa7h92snr-rocksdb-5.10.3-static/lib
patching script interpreter paths in /nix/store/xai53adxx2p68wfxs8gnpjzpa7h92snr-rocksdb-5.10.3-static
/nix/store/cmn97zbbzm2px7yga27k44x72gb68fjs-rocksdb-5.10.3-dev

@Mic92
Copy link
Member

Mic92 commented Apr 4, 2018 •
edited

@infinisil can you disable aarch64 support for now for both rocksdb/rocksdb_lite?

@infinisil
rocksdb: Disable aarch64
336ef91 
Because the build for it is broken
@infinisil
Copy link
Member Author

@Mic92 Done

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: rocksdb, rocksdb_lite

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@Mic92 Mic92 merged commit d5ee865 into NixOS:master Apr 4, 2018
@Mic92
Copy link
Member

Mic92 commented Apr 4, 2018

Is a backport required here?

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: rocksdb, rocksdb_lite

Partial log (click to expand)

/nix/store/w3xbrcbrvb0127l8y983q56hyayx02h2-rocksdb-5.10.3-dev
/nix/store/lkgb53pxif3x3sc0wmznfzc78h40m2xz-rocksdb-5.10.3-dev

@infinisil
Copy link
Member Author

@Mic92 Nope, it's all green on 18.03 https://hydra.nixos.org/job/nixos/release-18.03/nixpkgs.rocksdb_lite.x86_64-linux

@infinisil infinisil deleted the fix/rocksdblite branch April 18, 2018 20:32
@infinisil infinisil mentioned this pull request Apr 23, 2018
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@infinisil @GrahamcOfBorg @Mic92