Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

heptio-ark: init at 0.7.1 #38423

Merged
merged 1 commit into from Apr 13, 2018
Merged

heptio-ark: init at 0.7.1 #38423

merged 1 commit into from Apr 13, 2018

Conversation

mbode
Copy link
Contributor

@mbode mbode commented Apr 4, 2018

Motivation for this change

Add ark, a tool for Kubernetes backups.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Apr 4, 2018

/nix/store/hf4jbx5q8s29vnhpf63ick63wmabnapc-heptio-ark-0.7.1-bin/bin/generate should be deleted in the package. It is only a build time artifact.

};

meta = with stdenv.lib; {
description = "A utility for managing disaster recovery, specifically for your Kubernetes cluster resources and persistent volumes.";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No dot at the end of a description

@mbode
Copy link
Contributor Author

mbode commented Apr 12, 2018

@Mic92 @nlewo done, thanks for looking at it!

@nlewo
Copy link
Member

nlewo commented Apr 13, 2018

@mbode thks

@nlewo nlewo merged commit 4043fff into NixOS:master Apr 13, 2018
@mbode mbode deleted the heptio-ark_0_7_1 branch April 16, 2018 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants