Disable specs using GB2312 encoding on musl (fixes #3976) #5867
Conversation
Musl libc does not support GB2312 encoding. Fixes crystal-lang#3976
|
With this patch and #5866 all specs pass on x86_64 and aarch64 Alpine Linux* (musl)! 🎉 * when building with OpenSSL instead of LibreSSL |
|
Not all of these seem to be specifically about this encoding but rather any encoding that's not UTF. So we probably should switch those to a more supported encoding or at least add versions that work for musl, instead of just disabling them |
|
Yes, let's keep the failing specs as a reminder that we should change them to use a more broadly supported non-UTF encoding. |
|
Could wrap them in |
|
There have been pending specs in this repo that have been pending since before I even knew what crystal was. I think it's unlikely that pending specs will get noticed. |
|
And since you don’t run tests against musl on CI, it’s unlikely that anyone will notice that they are broken… :/ |
|
Sure, but the difference is in the semantics: failing specs means it is broken and pending means, this needs to be implemented but it's mostly usable. |
|
Maybe ISO-8859-1 is supported in musl? |
Musl libc does not support GB2312 encoding.