Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init cconv at 0.6.3 #37821

Merged
merged 2 commits into from Apr 1, 2018
Merged

init cconv at 0.6.3 #37821

merged 2 commits into from Apr 1, 2018

Conversation

redfish64
Copy link
Contributor

@redfish64 redfish64 commented Mar 26, 2018

Motivation for this change

add cconv tool for conversion between simplified and traditional chinese text

Things done
  • [x ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • [x ] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • [ x] Tested execution of all binary files (usually in ./result/bin/)
  • [ x] Fits CONTRIBUTING.md.

@globin
Copy link
Member

globin commented Mar 30, 2018

Merge conflicting

sha256 = "82f46a94829f5a8157d6f686e302ff5710108931973e133d6e19593061b81d84";
};

buildInputs = [ autoconf automake libtool ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use nativeBuildInputs = [ autoreconfHook ]; instead of this and the autogen.sh below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants