Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/tor: expose control socket #37827

Merged
merged 1 commit into from Mar 26, 2018

Conversation

oxij
Copy link
Member

@oxij oxij commented Mar 26, 2018

Motivation for this change

#28938. Closes #28938.

Things done

@dotlambda
Copy link
Member

I'm getting

tor.service: Failed to set up mount namespacing: No such file or directory
tor.service: Failed at step NAMESPACE spawning /nix/store/a9xirkmx8vvw27v7vmdmqckps15c4r0c-unit-script/bin/tor-pre-start: No such file or directory

after upgrading to the latest unstable channel.

I'm not sure what's causing it, but shouldn't we use RuntimeDir and StateDirectory for creating the directories? See https://www.freedesktop.org/software/systemd/man/systemd.exec.html#RuntimeDirectory=.

@dotlambda
Copy link
Member

I guess in order to create /run/tor in preStart, we'd need PermissionsStartOnly = true.

@oxij oxij mentioned this pull request Jun 11, 2018
2 tasks
@oxij oxij deleted the pull/28938-tor-control-port branch September 8, 2018 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants