Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GHCJS: Fix GHCJS with haddock-library-1.4.3 #37842

Merged
merged 1 commit into from Apr 2, 2018
Merged

GHCJS: Fix GHCJS with haddock-library-1.4.3 #37842

merged 1 commit into from Apr 2, 2018

Conversation

ElvishJerricco
Copy link
Contributor

Motivation for this change

This is a placeholder. Once hackage-packages are regenerated after #37834, this will use haddock-library_1_4_3 to fix the GHCJS 8.0 builds

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

This was referenced Mar 26, 2018
Closed
Open
Closed
@ElvishJerricco ElvishJerricco force-pushed the fix-ghcjs-haddock-library-1.4.3 branch from c1686ce to 5da837a Compare April 2, 2018 04:23
@ElvishJerricco ElvishJerricco changed the title WIP: GHCJS: Fix GHCJS with haddock-library-1.4.3 GHCJS: Fix GHCJS with haddock-library-1.4.3 Apr 2, 2018
@ElvishJerricco
Copy link
Contributor Author

ElvishJerricco commented Apr 2, 2018 •
edited

@peti This works now. Tested with ghcjs-dom-hello (with cabal2nix --compiler ghcjs), which successfully runs in Firefox.

@peti
Copy link
Member

peti commented Apr 2, 2018

@GrahamcOfBorg build haskell.compiler.ghcjsHEAD

peti
peti approved these changes Apr 2, 2018
View reviewed changes
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Let's wait for the test builds and then merge.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: haskell.compiler.ghcjsHEAD

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: haskell.compiler.ghcjsHEAD

Partial log (click to expand)

wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
/nix/store/4j4xhi33xsvs8064n89xihhi0q6994cx-ghcjs-0.2.020170323

@peti peti merged commit 5a6291f into NixOS:master Apr 2, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: haskell.compiler.ghcjsHEAD

Partial log (click to expand)

/nix/store/xgcyl3yf9r131bl8y0i6dcq8bkz1jzrh-ghcjs-0.2.020170323/lib/ghcjs-0.2.020170323/ghcjs-node/node_modules/har-validator/bin/har-validator: interpreter directive changed from "/usr/bin/env node" to "/nix/store/yq43w6hvqbcjlvafcnq3ni7d2g96kxf3-nodejs-6.14.1/bin/node"
/nix/store/xgcyl3yf9r131bl8y0i6dcq8bkz1jzrh-ghcjs-0.2.020170323/lib/ghcjs-0.2.020170323/ghcjs-node/node_modules/source-map/test/run-tests.js: interpreter directive changed from "/usr/bin/env node" to "/nix/store/yq43w6hvqbcjlvafcnq3ni7d2g96kxf3-nodejs-6.14.1/bin/node"
/nix/store/xgcyl3yf9r131bl8y0i6dcq8bkz1jzrh-ghcjs-0.2.020170323/lib/ghcjs-0.2.020170323/ghcjs-node/node_modules/sshpk/bin/sshpk-conv: interpreter directive changed from "/usr/bin/env node" to "/nix/store/yq43w6hvqbcjlvafcnq3ni7d2g96kxf3-nodejs-6.14.1/bin/node"
/nix/store/xgcyl3yf9r131bl8y0i6dcq8bkz1jzrh-ghcjs-0.2.020170323/lib/ghcjs-0.2.020170323/ghcjs-node/node_modules/sshpk/bin/sshpk-sign: interpreter directive changed from "/usr/bin/env node" to "/nix/store/yq43w6hvqbcjlvafcnq3ni7d2g96kxf3-nodejs-6.14.1/bin/node"
/nix/store/xgcyl3yf9r131bl8y0i6dcq8bkz1jzrh-ghcjs-0.2.020170323/lib/ghcjs-0.2.020170323/ghcjs-node/node_modules/sshpk/bin/sshpk-verify: interpreter directive changed from "/usr/bin/env node" to "/nix/store/yq43w6hvqbcjlvafcnq3ni7d2g96kxf3-nodejs-6.14.1/bin/node"
/nix/store/xgcyl3yf9r131bl8y0i6dcq8bkz1jzrh-ghcjs-0.2.020170323/lib/ghcjs-0.2.020170323/ghcjs-node/node_modules/uuid/bin/uuid: interpreter directive changed from "/usr/bin/env node" to "/nix/store/yq43w6hvqbcjlvafcnq3ni7d2g96kxf3-nodejs-6.14.1/bin/node"
/nix/store/xgcyl3yf9r131bl8y0i6dcq8bkz1jzrh-ghcjs-0.2.020170323/lib/ghcjs-0.2.020170323/ghcjs-node/update.sh: interpreter directive changed from "/bin/bash" to "/nix/store/x030a63qdilnv02pkivfjg44pdxsh5km-bash-4.4-p19/bin/bash"
/nix/store/xgcyl3yf9r131bl8y0i6dcq8bkz1jzrh-ghcjs-0.2.020170323/lib/ghcjs-0.2.020170323/run.sh: interpreter directive changed from "/bin/sh" to "/nix/store/x030a63qdilnv02pkivfjg44pdxsh5km-bash-4.4-p19/bin/sh"
/nix/store/xgcyl3yf9r131bl8y0i6dcq8bkz1jzrh-ghcjs-0.2.020170323/lib/ghcjs-0.2.020170323/shims/utils/threefish/build_threefish_block.sh: interpreter directive changed from "/bin/bash" to "/nix/store/x030a63qdilnv02pkivfjg44pdxsh5km-bash-4.4-p19/bin/bash"
/nix/store/xgcyl3yf9r131bl8y0i6dcq8bkz1jzrh-ghcjs-0.2.020170323

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti peti approved these changes

Assignees
No one assigned
Labels
6.topic: haskell 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ElvishJerricco @peti @GrahamcOfBorg