Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

godot: 2.1.4 -> 3.0.2 #37851

Closed
wants to merge 2 commits into from
Closed

godot: 2.1.4 -> 3.0.2 #37851

wants to merge 2 commits into from

Conversation

augu5te
Copy link

@augu5te augu5te commented Mar 26, 2018

Motivation for this change

Make available the version 3, version 2 is considered as legacy.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Mar 26, 2018

similar: #34971 , #34421

@Twey
Copy link
Contributor

Twey commented Mar 26, 2018

Be careful — there is a sneaky impurity here: see my PR for details.

@Ekleog
Copy link
Member

Ekleog commented Mar 27, 2018

Thanks! However, now that #34971 is merged I guess this is no longer needed :) (well, on the next unstable bump at least)

@augu5te
Copy link
Author

augu5te commented Mar 30, 2018

Issue addressed by #34971

@augu5te augu5te closed this Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@augu5te @xeji @Twey @Ekleog @GrahamcOfBorg @Janik-Haag