Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly account for current limitations of RISC-V kernels #37803

Merged
merged 3 commits into from Mar 27, 2018
Merged

Explicitly account for current limitations of RISC-V kernels #37803

merged 3 commits into from Mar 27, 2018

Conversation

shlevy
Copy link
Member

@shlevy shlevy commented Mar 25, 2018

No description provided.

@shlevy shlevy requested a review from Ericson2314 March 25, 2018 21:55
@shlevy shlevy removed request for edolstra and nbp March 25, 2018 21:55
shlevy referenced this pull request Mar 25, 2018
@shlevy
Only build libseccomp on supported systems
3c57e77
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: kexectools, libseccomp

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: kexectools, libseccomp

Partial log (click to expand)

these paths will be fetched (0.00 MiB download, 0.01 MiB unpacked):
  /nix/store/kxfc1kcacriisw2mhb4yq6ki6p7fsmjm-libseccomp-2.3.3
copying path '/nix/store/kxfc1kcacriisw2mhb4yq6ki6p7fsmjm-libseccomp-2.3.3' from 'https://cache.nixos.org'...
/nix/store/fm1ql96dshkg4hkkzzm2vnnd1d9v3qa0-kexec-tools-2.0.16
/nix/store/kxfc1kcacriisw2mhb4yq6ki6p7fsmjm-libseccomp-2.3.3

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: kexectools, libseccomp

Partial log (click to expand)

/nix/store/rg5zjwjl5rnnar3rb6hy649454wr2imd-kexec-tools-2.0.16
/nix/store/ydimk83fkc07sr575qkw8sqxhppsaryp-libseccomp-2.3.3

@Ericson2314
Copy link
Member

Ericson2314 commented Mar 26, 2018 •
edited

Hmm so hehe there's two things I mentioned on IRC, and I now see they were in direct conflict:

  1. It's better not to push local package problems into global lib/systems.nix
  2. It's better to (edit) allow disallow negative reasoning in arbitrary packages

Maybe it would be a good idea to do a meta.__badPlatforms so meta.platforms stays "good" and "open world friendly" but we still keep local concerns local?

Everything else looks great!

@shlevy
Copy link
Member Author

shlevy commented Mar 26, 2018

@Ericson2314 Hmm I'm a bit confused, this PR both moves stuff out of lib/systems and allows negative reasoning in individual packages... meta.platforms.{include,exclude} seems isomorphic to meta.{platforms,__badPlatforms}, especially since include is the default if none are specified.

@Ericson2314
Copy link
Member

Ericson2314 commented Mar 26, 2018 •
edited

@shlevy hahaha I meant to write "disallow" not "allow". Sorry for that. Indeed it is isomorphic. I'm just trying to quarantine the negative stuff as much as possible (and very unsure that what I propose is indeed the proper quarantine :)).

@shlevy
meta: Add badPlatforms attribute for platform blacklisting.
b048224
@shlevy
kexectools: Disable only on RISC-V if Linux.
cdf9a78 
The isKexecable flag treated Linux without kexec as just a normal
variant, when it really should be treated as a special case incurring
complexity debt to support.
@shlevy
libseccomp: Disable only on RISC-V if Linux.
26e8d58 
The isSeccomputable flag treated Linux without seccomp as just a
normal variant, when it really should be treated as a special case
incurring complexity debt to support.
@shlevy
Copy link
Member Author

shlevy commented Mar 27, 2018

@Ericson2314 Updated

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: kexectools, libseccomp

Partial log (click to expand)

these paths will be fetched (0.00 MiB download, 0.01 MiB unpacked):
  /nix/store/kxfc1kcacriisw2mhb4yq6ki6p7fsmjm-libseccomp-2.3.3
copying path '/nix/store/kxfc1kcacriisw2mhb4yq6ki6p7fsmjm-libseccomp-2.3.3' from 'https://cache.nixos.org'...
/nix/store/fm1ql96dshkg4hkkzzm2vnnd1d9v3qa0-kexec-tools-2.0.16
/nix/store/kxfc1kcacriisw2mhb4yq6ki6p7fsmjm-libseccomp-2.3.3

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: kexectools, libseccomp

Partial log (click to expand)

/nix/store/rg5zjwjl5rnnar3rb6hy649454wr2imd-kexec-tools-2.0.16
/nix/store/ydimk83fkc07sr575qkw8sqxhppsaryp-libseccomp-2.3.3

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: kexectools, libseccomp

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@srhb srhb merged commit 26e8d58 into NixOS:master Mar 27, 2018
@shlevy shlevy deleted the riscv-limitations branch March 27, 2018 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Ericson2314 approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 11-100 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@shlevy @GrahamcOfBorg @Ericson2314 @matthewbauer @srhb