Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util-linux: 2.31.1 -> 2.32 #37814

Merged
merged 2 commits into from Apr 30, 2018
Merged

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 25, 2018

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

dtzWill commented Mar 25, 2018

Whoops, wrong title... CLI github thing misbehaved, sorry!

@dtzWill dtzWill changed the title spice: 0.13.3 -> 0.14.0 ? util-linux: 2.31.1 -> 2.32 Mar 25, 2018
@dtzWill
Copy link
Member Author

dtzWill commented Mar 26, 2018

@GrahamcOfBorg build utillinux utillinuxMinimal

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: utillinux, utillinuxMinimal

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: utillinux, utillinuxMinimal

Partial log (click to expand)

../src/shared/dissect-image.c:584:55: warning: ‘generic_rw’ may be used uninitialized in this function [-Wmaybe-uninitialized]
[172/1461] Compiling C object 'src/shared/systemd-shared-238@sta/dns-domain.c.o'.
[173/1461] Compiling C object 'src/libsystemd/systemd@sta/sd-netlink_rtnl-message.c.o'.
[174/1461] Compiling C object 'src/libsystemd/systemd@sta/sd-bus_bus-socket.c.o'.
[175/1461] Compiling C object 'src/login/logind-core@sta/logind-dbus.c.o'.
[176/1461] Compiling C object 'src/libsystemd/systemd@sta/sd-bus_sd-bus.c.o'.
ninja: build stopped: subcommand failed.
builder for '/nix/store/gfwy9mxvbhfc7smv2fm26w2y81xhwl9x-systemd-238.drv' failed with exit code 1
cannot build derivation '/nix/store/9k9cxr7ch5h6qx7cys9xasw8ycz3d2xs-util-linux-2.32.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/9k9cxr7ch5h6qx7cys9xasw8ycz3d2xs-util-linux-2.32.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: utillinux, utillinuxMinimal

Partial log (click to expand)

                 from ../src/basic/hashmap.h:30,
                 from ../src/shared/bus-util.h:31,
                 from ../src/core/timer.c:25:
../src/basic/missing.h:528:17: error: expected identifier before numeric constant
 #define MS_MOVE 8192
                 ^
ninja: build stopped: subcommand failed.
builder for '/nix/store/a1mh59q1jxjppc3pwfiiksw56ydaw08r-systemd-238.drv' failed with exit code 1
cannot build derivation '/nix/store/jmyyjgzrn2qffyhvmdaz8c33gbcadszi-util-linux-2.32.drv': 1 dependencies couldn't be built
error: build of '/nix/store/jmyyjgzrn2qffyhvmdaz8c33gbcadszi-util-linux-2.32.drv' failed

@dtzWill
Copy link
Member Author

dtzWill commented Mar 26, 2018

Hmm, looks like this is upstream issue systemd/systemd#8507 .

@dtzWill
Copy link
Member Author

dtzWill commented Mar 26, 2018

Nevermind for now, sorry it worked in my tree! O:).

@dtzWill dtzWill closed this Mar 26, 2018
@dtzWill dtzWill reopened this Apr 29, 2018
@dtzWill
Copy link
Member Author

dtzWill commented Apr 29, 2018

@GrahamcOfBorg build systemd

@dtzWill
Copy link
Member Author

dtzWill commented Apr 29, 2018

@GrahamcOfBorg test systemd

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: systemd

Partial log (click to expand)

Cannot nix-instantiate `systemd' because:
�[31;1merror:�[0m while evaluating 'callPackageWith' at �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix�[0m:113:35, called from �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/top-level/all-packages.nix�[0m:13988:13:
while evaluating 'makeOverridable' at �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix�[0m:72:24, called from �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix�[0m:117:8:
while evaluating anonymous function at �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/systemd/default.nix�[0m:1:1, called from �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix�[0m:74:12:
assertion failed at �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/systemd/default.nix�[0m:16:1

@dtzWill dtzWill requested a review from adisbladis April 29, 2018 21:59
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: systemd

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/vyb3ka9bks2nzraibmvx9kwl3bcx2nhc-systemd-238-man
gzipping man pages under /nix/store/vyb3ka9bks2nzraibmvx9kwl3bcx2nhc-systemd-238-man/share/man/
strip is /nix/store/fzj1a9khx6wwp3zlf8lkf6kv17x1g5gb-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/vyb3ka9bks2nzraibmvx9kwl3bcx2nhc-systemd-238-man
checking for references to /build in /nix/store/vyb3ka9bks2nzraibmvx9kwl3bcx2nhc-systemd-238-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/vmfsv7hzvn3nchh2pibchki9sidd00xg-systemd-238-dev
strip is /nix/store/fzj1a9khx6wwp3zlf8lkf6kv17x1g5gb-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/vmfsv7hzvn3nchh2pibchki9sidd00xg-systemd-238-dev/lib
patching script interpreter paths in /nix/store/vmfsv7hzvn3nchh2pibchki9sidd00xg-systemd-238-dev
checking for references to /build in /nix/store/vmfsv7hzvn3nchh2pibchki9sidd00xg-systemd-238-dev...

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: systemd

Partial log (click to expand)

Cannot nix-instantiate `systemd' because:
�[31;1merror:�[0m while evaluating 'callPackageWith' at �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix�[0m:113:35, called from �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/top-level/all-packages.nix�[0m:13988:13:
while evaluating 'makeOverridable' at �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix�[0m:72:24, called from �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix�[0m:117:8:
while evaluating anonymous function at �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/systemd/default.nix�[0m:1:1, called from �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix�[0m:74:12:
assertion failed at �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/systemd/default.nix�[0m:16:1

@7c6f434c
Copy link
Member

test systemd is really optimistic for a quasi-stdenv rebuild… my builder isn't even loaded by anything else but I would still expect timeout… but we'll see.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: systemd

Partial log (click to expand)

gzipping man pages under /nix/store/vyb3ka9bks2nzraibmvx9kwl3bcx2nhc-systemd-238-man/share/man/
strip is /nix/store/fzj1a9khx6wwp3zlf8lkf6kv17x1g5gb-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/vyb3ka9bks2nzraibmvx9kwl3bcx2nhc-systemd-238-man
checking for references to /build in /nix/store/vyb3ka9bks2nzraibmvx9kwl3bcx2nhc-systemd-238-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/vmfsv7hzvn3nchh2pibchki9sidd00xg-systemd-238-dev
strip is /nix/store/fzj1a9khx6wwp3zlf8lkf6kv17x1g5gb-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/vmfsv7hzvn3nchh2pibchki9sidd00xg-systemd-238-dev/lib
patching script interpreter paths in /nix/store/vmfsv7hzvn3nchh2pibchki9sidd00xg-systemd-238-dev
checking for references to /build in /nix/store/vmfsv7hzvn3nchh2pibchki9sidd00xg-systemd-238-dev...
/nix/store/8vc141qahpx853nd5y3bf5awc17pi07v-systemd-238

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.systemd

Partial log (click to expand)

machine# [    5.501101] display-manager[699]: (**) Power Button: Applying InputClass "Keyboard catchall"
machine# [    5.502310] display-manager[699]: (**) Power Button: Applying InputClass "evdev keyboard catchall"
machine# [    5.503446] display-manager[699]: (II) LoadModule: "evdev"
machine: exit status 0
2 out of 2 tests succeeded
test script finished in 19.35s
cleaning up
killing machine (pid 634)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: systemd

Partial log (click to expand)

gzipping man pages under /nix/store/9pyscmijldifmy8ghigi0h6l54x9r31b-systemd-238-man/share/man/
strip is /nix/store/a8dd4rd03jylyb82ndx5r9f4rjp0nprn-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/9pyscmijldifmy8ghigi0h6l54x9r31b-systemd-238-man
checking for references to /build in /nix/store/9pyscmijldifmy8ghigi0h6l54x9r31b-systemd-238-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/ydrlskbqcbvaa0kipxvby3z31391m5b0-systemd-238-dev
strip is /nix/store/a8dd4rd03jylyb82ndx5r9f4rjp0nprn-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ydrlskbqcbvaa0kipxvby3z31391m5b0-systemd-238-dev/lib
patching script interpreter paths in /nix/store/ydrlskbqcbvaa0kipxvby3z31391m5b0-systemd-238-dev
checking for references to /build in /nix/store/ydrlskbqcbvaa0kipxvby3z31391m5b0-systemd-238-dev...
/nix/store/04hr2vymd6wr0wpp9mbi1d0cw62i1nw5-systemd-238

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: systemd

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/s0w3rr3grfq78svmp8kn2r0jnmmxw0i6-libidn2-2.0.4-info
strip is /nix/store/a8dd4rd03jylyb82ndx5r9f4rjp0nprn-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/s0w3rr3grfq78svmp8kn2r0jnmmxw0i6-libidn2-2.0.4-info
checking for references to /build in /nix/store/s0w3rr3grfq78svmp8kn2r0jnmmxw0i6-libidn2-2.0.4-info...
shrinking RPATHs of ELF executables and libraries in /nix/store/am7rh9ci8cbyk6v8pb9hxrqq2wrbambc-libidn2-2.0.4-devdoc
gzipping man pages under /nix/store/am7rh9ci8cbyk6v8pb9hxrqq2wrbambc-libidn2-2.0.4-devdoc/share/man/
strip is /nix/store/a8dd4rd03jylyb82ndx5r9f4rjp0nprn-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/am7rh9ci8cbyk6v8pb9hxrqq2wrbambc-libidn2-2.0.4-devdoc
checking for references to /build in /nix/store/am7rh9ci8cbyk6v8pb9hxrqq2wrbambc-libidn2-2.0.4-devdoc...
/nix/store/04hr2vymd6wr0wpp9mbi1d0cw62i1nw5-systemd-238

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: tests.systemd

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/l1w9hq3hl911y7isackmwij3fvlm9vyb-nixos-test-driver
strip is /nix/store/a8dd4rd03jylyb82ndx5r9f4rjp0nprn-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/l1w9hq3hl911y7isackmwij3fvlm9vyb-nixos-test-driver/lib  /nix/store/l1w9hq3hl911y7isackmwij3fvlm9vyb-nixos-test-driver/bin
patching script interpreter paths in /nix/store/l1w9hq3hl911y7isackmwij3fvlm9vyb-nixos-test-driver
/nix/store/l1w9hq3hl911y7isackmwij3fvlm9vyb-nixos-test-driver/bin/.nixos-test-driver-wrapped: interpreter directive changed from " /somewhere/perl -w" to "/nix/store/kfi0h0903cask6dfcjssx60wx6jf0wk5-perl-5.24.3/bin/perl -w"
checking for references to /build in /nix/store/l1w9hq3hl911y7isackmwij3fvlm9vyb-nixos-test-driver...
cannot build derivation '/nix/store/aayh3q7j7ah3xwjnfk6x1k0wqzkj7hs4-nixos-test-driver-systemd.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/blawaysbx0k49pnvwjpzcsk0wdhq6grw-vm-test-run-systemd.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/blawaysbx0k49pnvwjpzcsk0wdhq6grw-vm-test-run-systemd.drv' failed

@dtzWill
Copy link
Member Author

dtzWill commented Apr 30, 2018

No sure what the problem was on the aarch64 builder-- if it was timeout (which would make sense) it usually says so?

Let's try this again...

@GrahamcOfBorg test systemd

@7c6f434c
Copy link
Member

It's complicated. The 1-hour timeout is apparently per-derivation… There is a gfortran timeout and a linux kernel timeout at 73%, but Mesa build continues, as do some other builds… A bit surreal, sure.

@dtzWill
Copy link
Member Author

dtzWill commented Apr 30, 2018

Oh, I didn't see those :3. Thanks for the explanation!

@dtzWill dtzWill merged commit 919dda7 into NixOS:staging Apr 30, 2018
@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: tests.systemd

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/6pd6v5x5n81g96w0r9ysb393n5nxazdl-nixos-test-driver
strip is /nix/store/sp20jsyax3nv6g16ybyn01lhvz6qjy6l-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/6pd6v5x5n81g96w0r9ysb393n5nxazdl-nixos-test-driver/lib  /nix/store/6pd6v5x5n81g96w0r9ysb393n5nxazdl-nixos-test-driver/bin
patching script interpreter paths in /nix/store/6pd6v5x5n81g96w0r9ysb393n5nxazdl-nixos-test-driver
/nix/store/6pd6v5x5n81g96w0r9ysb393n5nxazdl-nixos-test-driver/bin/.nixos-test-driver-wrapped: interpreter directive changed from " /somewhere/perl -w" to "/nix/store/64fhhgsfab7yvnksn15dyzmvhy99ng5m-perl-5.24.3/bin/perl -w"
checking for references to /build in /nix/store/6pd6v5x5n81g96w0r9ysb393n5nxazdl-nixos-test-driver...
cannot build derivation '/nix/store/4iifmmyy789dcq8mn0p62gqar4y8f3v3-nixos-test-driver-systemd.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/p7x7i2la7sb0xd30hcfmcb02www8diwf-vm-test-run-systemd.drv': 1 dependencies couldn't be built
error: build of '/nix/store/p7x7i2la7sb0xd30hcfmcb02www8diwf-vm-test-run-systemd.drv' failed

@dtzWill dtzWill deleted the update/util-linux-2.32 branch April 30, 2018 20:48
@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: tests.systemd

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/3k44jpapbbw2dk2vayn8rp5dnrqfj6p9-nixos-test-driver
strip is /nix/store/zfaw1lpb8v14qkay8yw82xkwxvpd6v5x-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/3k44jpapbbw2dk2vayn8rp5dnrqfj6p9-nixos-test-driver/lib  /nix/store/3k44jpapbbw2dk2vayn8rp5dnrqfj6p9-nixos-test-driver/bin
patching script interpreter paths in /nix/store/3k44jpapbbw2dk2vayn8rp5dnrqfj6p9-nixos-test-driver
/nix/store/3k44jpapbbw2dk2vayn8rp5dnrqfj6p9-nixos-test-driver/bin/.nixos-test-driver-wrapped: interpreter directive changed from " /somewhere/perl -w" to "/nix/store/1gh1ik8hb4flw9wdah7crmblcc835j42-perl-5.24.3/bin/perl -w"
checking for references to /build in /nix/store/3k44jpapbbw2dk2vayn8rp5dnrqfj6p9-nixos-test-driver...
cannot build derivation '/nix/store/iqycnbz0c1p1hzij9i75zgx23k2mqzrb-nixos-test-driver-systemd.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/r4fmrb7dlhv4p95h174lvcy12azxiwhx-vm-test-run-systemd.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/r4fmrb7dlhv4p95h174lvcy12azxiwhx-vm-test-run-systemd.drv' failed

@vcunat
Copy link
Member

vcunat commented May 5, 2018

This fixes CVE-2018-7738.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants