unifi, nixos/unifi: support LTS (5.6.36) and release (5.7.20) #37799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badmutex
changed the title
|
Related to #36612 |
globin
requested changes
Mar 30, 2018
| ''; | ||
| }; | ||
|
|
||
| services.unifi.unifi = mkOption { |
There was a problem hiding this comment.
I'd prefer this being called package
|
|
||
| services.unifi.unifi = mkOption { | ||
| type = types.package; | ||
| default = pkgs.unifiLTS; |
There was a problem hiding this comment.
You need to add defaultText = "pkgs.unifiLTS"; to make sure that the manual does not depend on unifiLTS (which is the error in the PR CI status), same for the other package options.
There was a problem hiding this comment.
Thank you for pointing that out! I did not know about defaultText.
Ubiquiti has both a LTS and current version of their Unifi controller software. The latter adds new features, but may drop support for some devices. This adds the capability to use either for the unifi module but defaults to the LTS version, which was the previous behavior.
|
Mind taking another look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Ubiquiti has both a LTS and current version of their Unifi controller software.
The latter adds new features, but may drop support for some devices.
This adds the capability to use either for the
unifimodule but defaults to the LTS version, which was the previous behavior.Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)