Skip to content

Critical error - CKAN is showing and installing the wrong mod versions #2390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
linuxgurugamer opened this issue Mar 26, 2018 · 6 comments
Closed

Critical error - CKAN is showing and installing the wrong mod versions #2390

linuxgurugamer opened this issue Mar 26, 2018 · 6 comments
Labels
Needs more info We need more info

Comments

@linuxgurugamer
Copy link
Contributor

linuxgurugamer commented Mar 26, 2018 •
edited
Loading

Specifically, if a .version file for a mod is only listing a specific KSP version, ie: 1.4.1, and I start CKAN on a 1.3.1 version game, it is showing me that mod as being available for the game

This is a critical error and is part of why people don't trust CKAN.

This happens to be on a Windows 10 system

I'm in the middle of adopting KSP-AVC, and can help you with the logic, if you need help.
@linuxgurugamer linuxgurugamer added the Bug Something is not working as intended label Mar 26, 2018
@HebaruSan
Copy link
Member

Need an example.

Sorry, something went wrong.

@HebaruSan HebaruSan added the Needs more info We need more info label Mar 26, 2018
@linuxgurugamer
Copy link
Contributor Author

linuxgurugamer commented Mar 26, 2018 •
edited
Loading

working on it, the one I was looking at had a bad file in github :-(

Sorry, something went wrong.

@linuxgurugamer
Copy link
Contributor Author

Closing issue, was a bad file.
sorry

Sorry, something went wrong.

@HebaruSan HebaruSan removed the Bug Something is not working as intended label Mar 26, 2018
@linuxgurugamer
Copy link
Contributor Author

Ok. got it to happen again:
CKAN 1.23.0
KSP 1.3.1
Mod: Custom Barn Kit
It installed 1.1.17.0, even though the ranges were from 1.4.0 to 1.4.1

{
    "NAME": "CustomBarnKit",
    "URL": "https://ksp.sarbian.com/jenkins/job/CustomBarnKit/lastSuccessfulBuild/artifact/CustomBarnKit/CustomBarnKit.version",
    "DOWNLOAD": "http://forum.kerbalspaceprogram.com/index.php?/topic/109027-/",
    "VERSION":{
        "MAJOR": 1,
        "MINOR": 1,
        "PATCH": 17,
        "BUILD": 0
    },
    "KSP_VERSION": {
        "MAJOR": 1,
        "MINOR": 4,
        "PATCH": 1
    },
    "KSP_VERSION_MIN": {
        "MAJOR": 1,
        "MINOR": 4,
        "PATCH": 0
    },
    "KSP_VERSION_MAX": {
        "MAJOR": 1,
        "MINOR": 4,
        "PATCH": 1
    }
}

@HebaruSan
Copy link
Member

That's just the min version being hard coded in the netkan:

https://github.com/KSP-CKAN/NetKAN/blob/870b74980eafbd89ebe5a0c53c02d166a90ef405/NetKAN/CustomBarnKit.netkan#L14-L15

@HebaruSan HebaruSan mentioned this issue Mar 29, 2018
Merged
@linuxgurugamer
Copy link
Contributor Author

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs more info We need more info
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HebaruSan @linuxgurugamer