Fixed setting internal thread size.

On FreeBSD, setting the stack to 4096 bytes for threads like the Console Listener was not sufficient. This resulted in a SEGV while booting Rubinius, which happens before the signal handler has been set up, so nothing is shown in the logs. This also causes Rubinius to abort while trying to build Melbourne, leaving Rubinius in a very difficult to debug configuration.
rubinius · May 2, 2016 · 4b2a14b · 4b2a14b
1 parent 0b306fb
commit 4b2a14b
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/machine/internal_threads.hpp b/machine/internal_threads.hpp
@@ -26,9 +26,8 @@ namespace rubinius {
   public:
 
     enum StackSize {
-      eSmall  = 0x1000,
-      eLarge  = 0x10000,
-      eXLarge = 0x100000,
+      eSmall = 0x10000,
+      eLarge = 0x100000,
     };
 
     InternalThread(STATE, std::string name, StackSize stack_size=eLarge);

diff --git a/machine/jit/llvm/state.cpp b/machine/jit/llvm/state.cpp
@@ -90,7 +90,7 @@ namespace rubinius {
   static const bool debug_search = false;
 
   LLVMState::LLVMState(STATE)
-    : InternalThread(state, "rbx.jit", InternalThread::eXLarge)
+    : InternalThread(state, "rbx.jit", InternalThread::eLarge)
     , state_(0)
     , config_(state->shared().config)
     , compile_list_(state)

diff --git a/machine/memory/finalizer.cpp b/machine/memory/finalizer.cpp
@@ -76,7 +76,7 @@ namespace memory {
   }
 
   FinalizerThread::FinalizerThread(STATE)
-    : InternalThread(state, "rbx.finalizer", InternalThread::eXLarge)
+    : InternalThread(state, "rbx.finalizer", InternalThread::eLarge)
     , lists_(NULL)
     , live_list_(NULL)
     , process_list_(NULL)