-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Another failure to pass arguments when rspec loads files using Refinements #3826
Comments
Ok, so I suspect what's happening here is that it's finding the normal Module#included – which does require an argument – rather than some incuded you've refined into this body, yes? This may be fixed by work I committed late last week and today that improves the search logic for refinements. I'll kick the snapshot build at http://ci.jrubyorg and you can let me know if it looks better. |
Also...I didn't find (in quick inspection) any instructions on how to get up a test run. If I could run your suite it might be easy for me to shake out any remaining bugs. |
Since this might have been fixed by additional work on refinements, and since we're running out of time for 9.1, I'm punting this to 9.1.1.0. @estolfo Try to confirm last night's 9.1 snapshot. If it's still an issue and you can get us a way to reproduce it, we might be able to get it into 9.1. |
Thanks so much for working on this, @headius |
@estolfo I recommend that nobody ever use refinements, for exactly those reasons :-) We do appreciate having bug reports since it is a supported feature and we intend to make it work right. If you are still able to verify this bug, that would be great. However, if you won't be able to verify or if you want to close the bug, that's fine too. |
Hi @headius |
I'm closing this and will open another issue when I have the chance to get back to trying out Refinements in Mongoid. Thanks! |
Summary
I opened this issue last week. The specific error noted in the issue description has indeed gone away with the fix applied in this commit but it seems that there is another issue.
This is the line from where the error is thrown.
This is the stack trace when I run rspec:
Environment
The text was updated successfully, but these errors were encountered: