Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Truffle] BigDecimal marshaling should include precision information #3860

Closed
nirvdrum opened this issue May 6, 2016 · 4 comments
Closed

[Truffle] BigDecimal marshaling should include precision information #3860

nirvdrum opened this issue May 6, 2016 · 4 comments
Milestone
Non-Release

Comments

@nirvdrum
Copy link
Contributor

nirvdrum commented May 6, 2016

The marshaled output and parsing logic for BigDecimal doesn't deal with precision in JRuby+Truffle. While the format is internally consistent, it doesn't work with other implementations. This is problematic when dealing with persistent serialized objects, where interop could become an issue.
@chrisseaton
Copy link
Contributor

I can't even find where the marshal code for BigDecimal is. How does it work?

@pitr-ch
Copy link
Member

pitr-ch commented Oct 31, 2016

I does not have proper implementation

jruby/lib/ruby/truffle/truffle/bigdecimal.rb

Line 255 in b235ce7

def _dump(level=nil)

@chrisseaton
Copy link
Contributor

Ah so that's the cause of all this! Ok I can probably fill that in with the proper code.

@chrisseaton
Copy link
Contributor

Fixed in d2df698.

The marshal output still isn't exactly the same as the other implementations, but it seems to be compatible. We should aim to make all marshal output bit identical to MRI.

@enebo enebo added this to the truffle-dev milestone Nov 9, 2016
@enebo enebo added this to the Non-Release milestone Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Non-Release
Development

No branches or pull requests
4 participants
@nirvdrum @enebo @pitr-ch @chrisseaton