Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixnum#bit_length - uses bit inversion when the value is negative #3833

Merged
merged 1 commit into from
Apr 28, 2016

Conversation

lucasallan
Copy link
Member

Making sure the behaviour matches MRI https://github.com/ruby/ruby/blob/trunk/numeric.c#L4280

Thanks @jkr2255

@headius
Copy link
Member

headius commented Apr 28, 2016

Nice!

@headius headius merged commit 85212ad into jruby:master Apr 28, 2016
@headius
Copy link
Member

headius commented Apr 28, 2016

If you haven't already, can you add a ruby/spec for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants