Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Truffle] accept expression and parameter names in SnippetNode#execute #3815

Merged
merged 1 commit into from
Apr 22, 2016

Conversation

pitr-ch
Copy link
Member

@pitr-ch pitr-ch commented Apr 20, 2016

No description provided.

@pitr-ch pitr-ch added this to the truffle-dev milestone Apr 20, 2016
if (directCallNode == null) {
CompilerDirectives.transferToInterpreter();

this.expression = expression;
parameters = new String[arguments.length / 2];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assert arguments.length is even first maybe?

@eregon
Copy link
Member

eregon commented Apr 20, 2016

Exactly what I had in mind, perfect!

"right",
getSize(array),
"block",
block);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would format these pairs onto the same line, as "key", value.

@pitr-ch pitr-ch merged commit 3b426d6 into jruby:master Apr 22, 2016
@pitr-ch pitr-ch deleted the snippet branch April 22, 2016 09:37
@enebo enebo added this to the Non-Release milestone Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants